Skip to content

gh-108303: Move all inspect test files to test_inspect/ #109607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vstinner merged 5 commits into from
Oct 10, 2023
Merged

gh-108303: Move all inspect test files to test_inspect/ #109607

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
83b6a1d
gh-108303: Move all inspect test files to `test_inspect/`
sobolevn Sep 20, 2023
9e35f08
Update test_tokenize
sobolevn Sep 20, 2023
077ded8
Merge
sobolevn Sep 21, 2023
8d791b9
Address review
sobolevn Sep 21, 2023
44bd378
Merge
sobolevn Oct 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Lib/test/libregrtest/findtests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
"test_asyncio",
"test_concurrent_futures",
"test_future_stmt",
"test_inspect",
"test_multiprocessing_fork",
"test_multiprocessing_forkserver",
"test_multiprocessing_spawn",
Expand Down
1 change: 0 additions & 1 deletion Lib/test/test_import/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import builtins
import contextlib
import errno
import glob
import json
Expand Down
6 changes: 6 additions & 0 deletions Lib/test/test_inspect/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
import os
from test import support


def load_tests(*args):
return support.load_package_tests(os.path.dirname(__file__), *args)
Copy link
Member

@vstinner vstinner Sep 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@serhiy-storchaka: It would be nice if we could magically generate such function, instead of having to duplicate the same 4 lines in each test_xxx/ test package. Do you think that it would be possible?

0 Lib/test/inspect_fodder.py → Lib/test/test_inspect/inspect_fodder.py
View file
Open in desktop
File renamed without changes.
0 Lib/test/inspect_fodder2.py → Lib/test/test_inspect/inspect_fodder2.py
View file
Open in desktop
File renamed without changes.
0 Lib/test/inspect_stock_annotations.py → ...test_inspect/inspect_stock_annotations.py
View file
Open in desktop
File renamed without changes.
0 Lib/test/inspect_stringized_annotations.py → ...inspect/inspect_stringized_annotations.py
View file
Open in desktop
File renamed without changes.
0 Lib/test/inspect_stringized_annotations_2.py → ...spect/inspect_stringized_annotations_2.py
View file
Open in desktop
File renamed without changes.
11 changes: 6 additions & 5 deletions Lib/test/test_inspect.py → Lib/test/test_inspect/test_inspect.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,12 +36,13 @@
from test.support.import_helper import DirsOnSysPath, ready_to_import
from test.support.os_helper import TESTFN
from test.support.script_helper import assert_python_ok, assert_python_failure
from test import inspect_fodder as mod
from test import inspect_fodder2 as mod2
from test import support
from test import inspect_stock_annotations
from test import inspect_stringized_annotations
from test import inspect_stringized_annotations_2

from . import inspect_fodder as mod
from . import inspect_fodder2 as mod2
from . import inspect_stock_annotations
from . import inspect_stringized_annotations
from . import inspect_stringized_annotations_2


# Functions tested in this suite:
Expand Down
2 changes: 1 addition & 1 deletion Lib/test/test_tokenize.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1862,7 +1862,7 @@ def test_random_files(self):
# TODO: Remove this once we can untokenize PEP 701 syntax
testfiles.remove(os.path.join(tempdir, "test_fstring.py"))

for f in ('buffer', 'builtin', 'fileio', 'inspect', 'os', 'platform', 'sys'):
for f in ('buffer', 'builtin', 'fileio', 'os', 'platform', 'sys'):
testfiles.remove(os.path.join(tempdir, "test_%s.py") % f)

if not support.is_resource_enabled("cpu"):
Expand Down
1 change: 1 addition & 0 deletions Makefile.pre.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2168,6 +2168,7 @@ TESTSUBDIRS= idlelib/idle_test \
test/test_email \
test/test_email/data \
test/test_future_stmt \
test/test_inspect \
test/test_import \
test/test_import/data \
test/test_import/data/circular_imports \
Expand Down