Skip to content

gh-110164: regrtest disables random if SOURCE_DATE_EPOCH #110168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 1, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions Lib/test/libregrtest/main.py
Original file line number Diff line number Diff line change
Expand Up @@ -106,8 +106,6 @@ def __init__(self, ns: Namespace, _add_python_opts: bool = False):
self.fail_env_changed: bool = ns.fail_env_changed
self.fail_rerun: bool = ns.fail_rerun
self.forever: bool = ns.forever
self.randomize: bool = ns.randomize
self.random_seed: int | None = ns.random_seed
self.output_on_failure: bool = ns.verbose3
self.timeout: float | None = ns.timeout
if ns.huntrleaks:
Expand All @@ -129,6 +127,13 @@ def __init__(self, ns: Namespace, _add_python_opts: bool = False):
self.coverage_dir: StrPath | None = ns.coverdir
self.tmp_dir: StrPath | None = ns.tempdir

# Randomize
self.randomize: bool = ns.randomize
self.random_seed: int | None = ns.random_seed
if 'SOURCE_DATE_EPOCH' in os.environ:
self.randomize = False
self.random_seed = None

# tests
self.first_runtests: RunTests | None = None

Expand Down
8 changes: 8 additions & 0 deletions Lib/test/test_regrtest.py
Original file line number Diff line number Diff line change
Expand Up @@ -148,6 +148,14 @@ def test_randomize(self):
ns = self.parse_args([opt])
self.assertTrue(ns.randomize)

with os_helper.EnvironmentVarGuard() as env:
env['SOURCE_DATE_EPOCH'] = '1'

ns = self.parse_args(['--randomize'])
regrtest = main.Regrtest(ns)
self.assertFalse(regrtest.randomize)
self.assertIsNone(regrtest.random_seed)

def test_randseed(self):
ns = self.parse_args(['--randseed', '12345'])
self.assertEqual(ns.random_seed, 12345)
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
regrtest: If the ``SOURCE_DATE_EPOCH`` environment variable is defined,
regrtest now disables tests randomization. Patch by Victor Stinner.