-
-
Notifications
You must be signed in to change notification settings - Fork 31.9k
gh-110171: libregrtest
always sets random.seed
unless --no-use-randseed
is provided
#110172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…-use-randseed` is provided
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest to change setup_tests(). Replace:
if runtests.randomize:
random.seed(runtests.random_seed)
with:
random.seed(runtests.random_seed)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One last request on the Changelog entry, and then I think that we will be good.
Misc/NEWS.d/next/Tests/2023-10-01-10-27-02.gh-issue-110171.ZPlo0h.rst
Outdated
Show resolved
Hide resolved
|
|
|
Refs #110168
libregrtest
should always setrandom.seed
#110171