Skip to content

gh-110171: libregrtest always sets random.seed unless --no-use-randseed is provided #110172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Oct 4, 2023

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented Oct 1, 2023

@sobolevn
Copy link
Member Author

sobolevn commented Oct 1, 2023

Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest to change setup_tests(). Replace:

    if runtests.randomize:
        random.seed(runtests.random_seed)

with:

    random.seed(runtests.random_seed)      

@vstinner vstinner enabled auto-merge (squash) October 1, 2023 20:39
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last request on the Changelog entry, and then I think that we will be good.

@vstinner vstinner merged commit 1465386 into python:main Oct 4, 2023
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot s390x RHEL7 3.x has failed when building commit 1465386.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/179/builds/5648) and take a look at the build logs.
  4. Check if the failure is related to this commit (1465386) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/179/builds/5648

Failed tests:

  • test_venv

Failed subtests:

  • test_prompt - test.test_venv.BasicTest.test_prompt

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last):
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z/build/Lib/test/test_venv.py", line 646, in test_scm_ignore_files_git
    self.run_with_capture(venv.create, self.env_dir,
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z/build/Lib/test/test_venv.py", line 95, in run_with_capture
    func(*args, **kwargs)
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z/build/Lib/venv/__init__.py", line 491, in create
    builder.create(env_dir)
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z/build/Lib/venv/__init__.py", line 79, in create
    self.setup_python(context)
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z/build/Lib/venv/__init__.py", line 321, in setup_python
    copier(context.env_exe, path, relative_symlinks_ok=True)
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z/build/Lib/venv/__init__.py", line 243, in symlink_or_copy
    shutil.copyfile(src, dst)
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z/build/Lib/shutil.py", line 272, in copyfile
    _fastcopy_sendfile(fsrc, fdst)
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z/build/Lib/shutil.py", line 163, in _fastcopy_sendfile
    raise err from None
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z/build/Lib/shutil.py", line 149, in _fastcopy_sendfile
    sent = os.sendfile(outfd, infd, offset, blocksize)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
OSError: [Errno 28] No space left on device: '/tmp/test_python_g56bpm1l/tmpmumg1_of/bin/python' -> '/tmp/test_python_g56bpm1l/tmpmumg1_of/bin/python3.13'


Traceback (most recent call last):
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z/build/Lib/test/test_venv.py", line 410, in test_symlinking
    builder.create(self.env_dir)
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z/build/Lib/venv/__init__.py", line 79, in create
    self.setup_python(context)
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z/build/Lib/venv/__init__.py", line 321, in setup_python
    copier(context.env_exe, path, relative_symlinks_ok=True)
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z/build/Lib/venv/__init__.py", line 243, in symlink_or_copy
    shutil.copyfile(src, dst)
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z/build/Lib/shutil.py", line 272, in copyfile
    _fastcopy_sendfile(fsrc, fdst)
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z/build/Lib/shutil.py", line 163, in _fastcopy_sendfile
    raise err from None
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z/build/Lib/shutil.py", line 149, in _fastcopy_sendfile
    sent = os.sendfile(outfd, infd, offset, blocksize)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
OSError: [Errno 28] No space left on device: '/tmp/test_python_g56bpm1l/tmpbxrjp_g0/bin/python' -> '/tmp/test_python_g56bpm1l/tmpbxrjp_g0/bin/python3.13'


Traceback (most recent call last):
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z/build/Lib/test/test_venv.py", line 213, in test_prompt
    self.run_with_capture(builder.create, self.env_dir)
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z/build/Lib/test/test_venv.py", line 95, in run_with_capture
    func(*args, **kwargs)
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z/build/Lib/venv/__init__.py", line 79, in create
    self.setup_python(context)
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z/build/Lib/venv/__init__.py", line 321, in setup_python
    copier(context.env_exe, path, relative_symlinks_ok=True)
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z/build/Lib/venv/__init__.py", line 243, in symlink_or_copy
    shutil.copyfile(src, dst)
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z/build/Lib/shutil.py", line 272, in copyfile
    _fastcopy_sendfile(fsrc, fdst)
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z/build/Lib/shutil.py", line 163, in _fastcopy_sendfile
    raise err from None
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z/build/Lib/shutil.py", line 149, in _fastcopy_sendfile
    sent = os.sendfile(outfd, infd, offset, blocksize)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
OSError: [Errno 28] No space left on device: '/tmp/test_python_g56bpm1l/tmpwnjqebck/bin/python' -> '/tmp/test_python_g56bpm1l/tmpwnjqebck/bin/python3.13'

@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Fedora Stable Clang 3.x has failed when building commit 1465386.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/441/builds/4626) and take a look at the build logs.
  4. Check if the failure is related to this commit (1465386) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/441/builds/4626

Failed tests:

  • test.test_concurrent_futures.test_deadlock

Summary of the results of the build (if available):

==

Click to see traceback logs
Note: switching to '1465386720cd532a378a5cc1e6de9d96dd8fcc81'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by switching back to a branch.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -c with the switch command. Example:

  git switch -c <new-branch-name>

Or undo this operation with:

  git switch -

Turn off this advice by setting config variable advice.detachedHead to false

HEAD is now at 1465386720 gh-110171: `libregrtest` always sets `random.seed`  (#110172)
Switched to and reset branch 'main'

make: *** [Makefile:2020: buildbottest] Error 5

@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot ARM Raspbian 3.x has failed when building commit 1465386.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/424/builds/5093) and take a look at the build logs.
  4. Check if the failure is related to this commit (1465386) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/424/builds/5093

Summary of the results of the build (if available):

==

Click to see traceback logs
remote: Enumerating objects: 26, done.        
remote: Counting objects:   3% (1/26)        
remote: Counting objects:   7% (2/26)        
remote: Counting objects:  11% (3/26)        
remote: Counting objects:  15% (4/26)        
remote: Counting objects:  19% (5/26)        
remote: Counting objects:  23% (6/26)        
remote: Counting objects:  26% (7/26)        
remote: Counting objects:  30% (8/26)        
remote: Counting objects:  34% (9/26)        
remote: Counting objects:  38% (10/26)        
remote: Counting objects:  42% (11/26)        
remote: Counting objects:  46% (12/26)        
remote: Counting objects:  50% (13/26)        
remote: Counting objects:  53% (14/26)        
remote: Counting objects:  57% (15/26)        
remote: Counting objects:  61% (16/26)        
remote: Counting objects:  65% (17/26)        
remote: Counting objects:  69% (18/26)        
remote: Counting objects:  73% (19/26)        
remote: Counting objects:  76% (20/26)        
remote: Counting objects:  80% (21/26)        
remote: Counting objects:  84% (22/26)        
remote: Counting objects:  88% (23/26)        
remote: Counting objects:  92% (24/26)        
remote: Counting objects:  96% (25/26)        
remote: Counting objects: 100% (26/26)        
remote: Counting objects: 100% (26/26), done.        
remote: Compressing objects:   7% (1/13)        
remote: Compressing objects:  15% (2/13)        
remote: Compressing objects:  23% (3/13)        
remote: Compressing objects:  30% (4/13)        
remote: Compressing objects:  38% (5/13)        
remote: Compressing objects:  46% (6/13)        
remote: Compressing objects:  53% (7/13)        
remote: Compressing objects:  61% (8/13)        
remote: Compressing objects:  69% (9/13)        
remote: Compressing objects:  76% (10/13)        
remote: Compressing objects:  84% (11/13)        
remote: Compressing objects:  92% (12/13)        
remote: Compressing objects: 100% (13/13)        
remote: Compressing objects: 100% (13/13), done.        
remote: Total 14 (delta 12), reused 3 (delta 1), pack-reused 0        
From https://github.com/python/cpython
 * branch                  main       -> FETCH_HEAD
Note: switching to '1465386720cd532a378a5cc1e6de9d96dd8fcc81'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by switching back to a branch.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -c with the switch command. Example:

  git switch -c <new-branch-name>

Or undo this operation with:

  git switch -

Turn off this advice by setting config variable advice.detachedHead to false

HEAD is now at 1465386720 gh-110171: `libregrtest` always sets `random.seed`  (#110172)
Switched to and reset branch 'main'

In file included from Python/executor.c:87:
Python/executor_cases.c.h: In function ‘_PyUopExecute’:
Python/executor_cases.c.h:2309:31: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
 2309 |             PyObject *descr = (PyObject *)operand;
      |                               ^
Python/executor_cases.c.h:2328:31: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
 2328 |             PyObject *descr = (PyObject *)operand;
      |                               ^
./Modules/_testcapi/heaptype_relative.c: In function ‘make_sized_heaptypes’:
./Modules/_testcapi/heaptype_relative.c:60:28: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
   60 |                            (unsigned long long)data_ptr,
      |                            ^

make: *** [Makefile:2016: buildbottest] Error 5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants