Skip to content

Fix env var typo in perf profiling docs #110404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 5, 2023
Merged

Fix env var typo in perf profiling docs #110404

merged 1 commit into from
Oct 5, 2023

Conversation

haampie
Copy link
Contributor

@haampie haampie commented Oct 5, 2023

@bedevere-app bedevere-app bot added docs Documentation in the Doc dir skip news awaiting review labels Oct 5, 2023
@hugovk hugovk changed the title Fix typo in perf profiling docs Fix env var typo in perf profiling docs Oct 5, 2023
@hugovk hugovk added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes skip issue labels Oct 5, 2023
@hugovk hugovk merged commit a136206 into python:main Oct 5, 2023
@miss-islington
Copy link
Contributor

Thanks @haampie for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @haampie and @hugovk, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker a13620685f68957c965fca89343a0e91f95f1bab 3.11

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 5, 2023
Fix typo in docs
(cherry picked from commit a136206)

Co-authored-by: Harmen Stoppels <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Oct 5, 2023

GH-110414 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Oct 5, 2023
hugovk pushed a commit that referenced this pull request Oct 5, 2023
Fix env var typo in perf profiling docs (GH-110404)

Fix typo in docs
(cherry picked from commit a136206)

Co-authored-by: Harmen Stoppels <[email protected]>
@hugovk hugovk removed the needs backport to 3.11 only security fixes label Oct 5, 2023
@hugovk
Copy link
Member

hugovk commented Oct 5, 2023

This file doesn't exist for 3.11, no need to backport. Thanks for the PR!

@haampie haampie deleted the patch-2 branch October 6, 2023 09:47
@haampie
Copy link
Contributor Author

haampie commented Oct 6, 2023

@hugovk still doesn't work for me actually. Are you supposed to run it like

export PYTHONPERFSUPPORT=1
perf record -g python ...
perf report

instead?

@hugovk
Copy link
Member

hugovk commented Oct 6, 2023

I'm not on Linux so can't test it but that should also work, as should python -X perf script.py. Make sure you're using Python 3.12, it's new there.

Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants