gh-109888: Fix test_os _kill_with_event() on Windows #110421

vstinner · 2023-10-05T18:51:25Z

Replace os.kill() with proc.kill() which catchs PermissionError.

Rewrite _kill_with_event():

Use subprocess context manager ("with proc:").
Use sleeping_retry() to wait until the child process is ready.
Replace SIGINT with proc.kill() on error.
Replace 0.5 seconds with SHORT_TIMEOUT.

Issue: test_os.Win32KillTests: test_CTRL_BREAK_EVENT() failed on GHA Windows x64 #109888

Replace os.kill() with proc.kill() which catchs PermissionError. Rewrite _kill_with_event(): * Use subprocess context manager ("with proc:"). * Use sleeping_retry() to wait until the child process is ready. * Replace SIGINT with proc.kill() on error. * Replace 10 seconds with SHORT_TIMEOUT to wait until the process is ready. * Replace 0.5 seconds with SHORT_TIMEOUT to wait for the process exit.

miss-islington · 2023-10-05T21:40:54Z

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

…110421) Replace os.kill() with proc.kill() which catchs PermissionError. Rewrite _kill_with_event(): * Use subprocess context manager ("with proc:"). * Use sleeping_retry() to wait until the child process is ready. * Replace SIGINT with proc.kill() on error. * Replace 10 seconds with SHORT_TIMEOUT to wait until the process is ready. * Replace 0.5 seconds with SHORT_TIMEOUT to wait for the process exit. (cherry picked from commit aaf297c) Co-authored-by: Victor Stinner <[email protected]>

bedevere-app · 2023-10-05T21:41:10Z

GH-110442 is a backport of this pull request to the 3.12 branch.

bedevere-app · 2023-10-05T21:41:13Z

GH-110443 is a backport of this pull request to the 3.11 branch.

…110421) Replace os.kill() with proc.kill() which catchs PermissionError. Rewrite _kill_with_event(): * Use subprocess context manager ("with proc:"). * Use sleeping_retry() to wait until the child process is ready. * Replace SIGINT with proc.kill() on error. * Replace 10 seconds with SHORT_TIMEOUT to wait until the process is ready. * Replace 0.5 seconds with SHORT_TIMEOUT to wait for the process exit. (cherry picked from commit aaf297c) Co-authored-by: Victor Stinner <[email protected]>

bedevere-bot · 2023-10-05T22:04:23Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 FreeBSD 3.x has failed when building commit aaf297c.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/1223/builds/364) and take a look at the build logs.
Check if the failure is related to this commit (aaf297c) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/1223/builds/364

Failed tests:

test_interpreters

Summary of the results of the build (if available):

==

Click to see traceback logs

remote: Enumerating objects: 9, done.        
remote: Counting objects:  11% (1/9)        
remote: Counting objects:  22% (2/9)        
remote: Counting objects:  33% (3/9)        
remote: Counting objects:  44% (4/9)        
remote: Counting objects:  55% (5/9)        
remote: Counting objects:  66% (6/9)        
remote: Counting objects:  77% (7/9)        
remote: Counting objects:  88% (8/9)        
remote: Counting objects: 100% (9/9)        
remote: Counting objects: 100% (9/9), done.        
remote: Compressing objects:  25% (1/4)        
remote: Compressing objects:  50% (2/4)        
remote: Compressing objects:  75% (3/4)        
remote: Compressing objects: 100% (4/4)        
remote: Compressing objects: 100% (4/4), done.        
remote: Total 5 (delta 4), reused 2 (delta 1), pack-reused 0        
From https://github.com/python/cpython
 * branch                  main       -> FETCH_HEAD
Note: switching to 'aaf297c048694cd9652790f8b74e69f7ddadfbde'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by switching back to a branch.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -c with the switch command. Example:

  git switch -c <new-branch-name>

Or undo this operation with:

  git switch -

Turn off this advice by setting config variable advice.detachedHead to false

HEAD is now at aaf297c048 gh-109888: Fix test_os _kill_with_event() on Windows (#110421)
Switched to and reset branch 'main'

… (#110443) gh-109888: Fix test_os _kill_with_event() on Windows (GH-110421) Replace os.kill() with proc.kill() which catchs PermissionError. Rewrite _kill_with_event(): * Use subprocess context manager ("with proc:"). * Use sleeping_retry() to wait until the child process is ready. * Replace SIGINT with proc.kill() on error. * Replace 10 seconds with SHORT_TIMEOUT to wait until the process is ready. * Replace 0.5 seconds with SHORT_TIMEOUT to wait for the process exit. (cherry picked from commit aaf297c) Co-authored-by: Victor Stinner <[email protected]>

… (#110442) gh-109888: Fix test_os _kill_with_event() on Windows (GH-110421) Replace os.kill() with proc.kill() which catchs PermissionError. Rewrite _kill_with_event(): * Use subprocess context manager ("with proc:"). * Use sleeping_retry() to wait until the child process is ready. * Replace SIGINT with proc.kill() on error. * Replace 10 seconds with SHORT_TIMEOUT to wait until the process is ready. * Replace 0.5 seconds with SHORT_TIMEOUT to wait for the process exit. (cherry picked from commit aaf297c) Co-authored-by: Victor Stinner <[email protected]>

…0421) Replace os.kill() with proc.kill() which catchs PermissionError. Rewrite _kill_with_event(): * Use subprocess context manager ("with proc:"). * Use sleeping_retry() to wait until the child process is ready. * Replace SIGINT with proc.kill() on error. * Replace 10 seconds with SHORT_TIMEOUT to wait until the process is ready. * Replace 0.5 seconds with SHORT_TIMEOUT to wait for the process exit.

vstinner added tests Tests in the Lib/test dir needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Oct 5, 2023

bedevere-app bot added the awaiting review label Oct 5, 2023

bedevere-app bot mentioned this pull request Oct 5, 2023

test_os.Win32KillTests: test_CTRL_BREAK_EVENT() failed on GHA Windows x64 #109888

Closed

vstinner added the skip news label Oct 5, 2023

vstinner enabled auto-merge (squash) October 5, 2023 18:52

vstinner merged commit aaf297c into python:main Oct 5, 2023

vstinner deleted the test_os_kill_event branch October 5, 2023 21:40

bedevere-app bot removed the awaiting review label Oct 5, 2023

bedevere-app bot removed the needs backport to 3.12 only security fixes label Oct 5, 2023

bedevere-app bot removed the needs backport to 3.11 only security fixes label Oct 5, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

gh-109888: Fix test_os _kill_with_event() on Windows #110421

gh-109888: Fix test_os _kill_with_event() on Windows #110421

vstinner commented Oct 5, 2023 •

edited by bedevere-app bot

Loading

miss-islington commented Oct 5, 2023

bedevere-app bot commented Oct 5, 2023

bedevere-app bot commented Oct 5, 2023

bedevere-bot commented Oct 5, 2023

gh-109888: Fix test_os _kill_with_event() on Windows #110421

gh-109888: Fix test_os _kill_with_event() on Windows #110421

Conversation

vstinner commented Oct 5, 2023 • edited by bedevere-app bot Loading

miss-islington commented Oct 5, 2023

bedevere-app bot commented Oct 5, 2023

bedevere-app bot commented Oct 5, 2023

bedevere-bot commented Oct 5, 2023

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

vstinner commented Oct 5, 2023 •

edited by bedevere-app bot

Loading