Skip to content

[3.11] GH-94438: Restore ability to jump over None tests (GH-111237) #111338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 25, 2023
Merged

[3.11] GH-94438: Restore ability to jump over None tests (GH-111237) #111338

merged 1 commit into from
Oct 25, 2023

Conversation

savannahostrowski
Copy link
Member

@savannahostrowski savannahostrowski commented Oct 25, 2023 •
edited by bedevere-app bot
Loading

Was unable to automatically backport 3.11 for #111237 as some of the bytecode instructions changed in 3.12

cc: @brandtbucher

@bedevere-app bedevere-app bot mentioned this pull request Oct 25, 2023
Closed
3 tasks
@brandtbucher brandtbucher changed the title Backport 3.11 for gh-94438 [3.11] GH-94438: Restore ability to jump over None tests (GH-111237) Oct 25, 2023
@bedevere-app bedevere-app bot mentioned this pull request Oct 25, 2023
Merged
@bedevere-app bedevere-app bot added the type-bug An unexpected behavior, bug, or error label Oct 25, 2023
brandtbucher
brandtbucher approved these changes Oct 25, 2023
View reviewed changes
Copy link
Member

@brandtbucher brandtbucher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

Weird process nit: backport PR titles should have the same format as normal PRs, but with the branch name in square brackets at the start ("[3.X] GH-NNNNNN: Blah blah blah"). That way the bots can identify the backport and cross-reference stuff.

@brandtbucher brandtbucher enabled auto-merge (squash) October 25, 2023 20:29
@brandtbucher brandtbucher merged commit 12c7e50 into python:3.11 Oct 25, 2023
@savannahostrowski savannahostrowski deleted the backport-6640f1d-3.11 branch September 27, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandtbucher brandtbucher brandtbucher approved these changes

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Assignees
No one assigned
Labels
type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@savannahostrowski @brandtbucher