-
-
Notifications
You must be signed in to change notification settings - Fork 31.8k
gh-111495: add stub files for C API test modules #111586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-111495: add stub files for C API test modules #111586
Conversation
This is to reduce merge conflicts (Modules/Setup.stdlib.in) for subsequent pull requests for the issue.
Ok, all test modules for #111495 were added. @serhiy-storchaka, this is ready for review. BTW, perhaps this should be labeled "tests" automatically? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer to remove parameter names in declarations, but LGTM.
It could be an opportunity to re-order all lists in alphabetic order, but it would make more difficult to see what items were added. |
Thanks @skirpichev for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12. |
Sorry, @skirpichev and @serhiy-storchaka, I could not cleanly backport this to
|
I guess some changes were not backported to 3.12. @skirpichev could you please manually create a backport? |
On Tue, Oct 31, 2023 at 10:46:46PM -0700, Serhiy Storchaka wrote:
I guess some changes were not backported to 3.12. ***@***.*** could you
please manually create a backport?
Sure, I'll try.
|
…GH-111586) This is to reduce merge conflicts (Modules/Setup.stdlib.in) for subsequent pull requests for the issue. (cherry picked from commit 33ed5fa) Co-authored-by: Sergey B Kirpichev <[email protected]>
GH-111592 is a backport of this pull request to the 3.12 branch. |
This is to reduce merge conflicts (Modules/Setup.stdlib.in) for subsequent pull requests for the issue.
This is to reduce merge conflicts (Modules/Setup.stdlib.in) for subsequent pull requests for the issue.
This is to reduce merge conflicts (Modules/Setup.stdlib.in) for subsequent pull requests for the issue.
This is to reduce merge conflicts (Modules/Setup.stdlib.in) for subsequent pull requests for the issue.