Skip to content

gh-111495: add stub files for C API test modules #111586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 1, 2023

Conversation

skirpichev
Copy link
Member

@skirpichev skirpichev commented Nov 1, 2023

This is to reduce merge conflicts (Modules/Setup.stdlib.in) for subsequent pull requests for the issue.

This is to reduce merge conflicts (Modules/Setup.stdlib.in) for
subsequent pull requests for the issue.
@bedevere-app bedevere-app bot mentioned this pull request Nov 1, 2023
10 tasks
@skirpichev
Copy link
Member Author

So far there is only files from #111496, #111562 and #109647. More is coming.

CC @serhiy-storchaka

@skirpichev skirpichev marked this pull request as ready for review November 1, 2023 02:39
@skirpichev skirpichev requested a review from a team as a code owner November 1, 2023 02:39
@skirpichev
Copy link
Member Author

Ok, all test modules for #111495 were added. @serhiy-storchaka, this is ready for review.

BTW, perhaps this should be labeled "tests" automatically?

Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer to remove parameter names in declarations, but LGTM.

@serhiy-storchaka serhiy-storchaka added tests Tests in the Lib/test dir needs backport to 3.12 only security fixes skip news labels Nov 1, 2023
@serhiy-storchaka
Copy link
Member

It could be an opportunity to re-order all lists in alphabetic order, but it would make more difficult to see what items were added.

@serhiy-storchaka serhiy-storchaka merged commit 33ed5fa into python:main Nov 1, 2023
@miss-islington-app
Copy link

Thanks @skirpichev for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Sorry, @skirpichev and @serhiy-storchaka, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 33ed5fa69dbe25d64a910c450be527f4db9dc5dd 3.12

@serhiy-storchaka
Copy link
Member

I guess some changes were not backported to 3.12. @skirpichev could you please manually create a backport?

@skirpichev
Copy link
Member Author

skirpichev commented Nov 1, 2023 via email

@skirpichev skirpichev deleted the add-stubs-for-capi-tests branch November 1, 2023 06:03
skirpichev added a commit to skirpichev/cpython that referenced this pull request Nov 1, 2023
…GH-111586)

This is to reduce merge conflicts (Modules/Setup.stdlib.in) for
subsequent pull requests for the issue.
(cherry picked from commit 33ed5fa)

Co-authored-by: Sergey B Kirpichev <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Nov 1, 2023

GH-111592 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Nov 1, 2023
serhiy-storchaka pushed a commit that referenced this pull request Nov 1, 2023
…H-111592)

This is to reduce merge conflicts (Modules/Setup.stdlib.in) for
subsequent pull requests for the issue.
(cherry picked from commit 33ed5fa)
FullteaR pushed a commit to FullteaR/cpython that referenced this pull request Nov 3, 2023
This is to reduce merge conflicts (Modules/Setup.stdlib.in) for
subsequent pull requests for the issue.
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
This is to reduce merge conflicts (Modules/Setup.stdlib.in) for
subsequent pull requests for the issue.
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
This is to reduce merge conflicts (Modules/Setup.stdlib.in) for
subsequent pull requests for the issue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants