Skip to content

gh-112678: Declare Tkapp_CallDeallocArgs() as static #112679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 4, 2023

Conversation

chrstphrchvz
Copy link
Contributor

@chrstphrchvz chrstphrchvz commented Dec 3, 2023

…as per PEP 7.

This should make no difference in functionality. According to llvm-nm -gU Modules/_tkinter.o there are no other similar issues in this file.

@AlexWaygood AlexWaygood changed the title gh-1126678: Declare Tkapp_CallDeallocArgs() as static gh-112678: Declare Tkapp_CallDeallocArgs() as static Dec 3, 2023
@miss-islington-app
Copy link

Thanks @chrstphrchvz for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Thanks @chrstphrchvz for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@bedevere-app
Copy link

bedevere-app bot commented Dec 4, 2023

GH-112690 is a backport of this pull request to the 3.12 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 4, 2023
…nGH-112679)

(cherry picked from commit 23e001f)

Co-authored-by: Christopher Chavez <[email protected]>
@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Dec 4, 2023
@bedevere-app
Copy link

bedevere-app bot commented Dec 4, 2023

GH-112691 is a backport of this pull request to the 3.11 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 4, 2023
…nGH-112679)

(cherry picked from commit 23e001f)

Co-authored-by: Christopher Chavez <[email protected]>
@bedevere-app bedevere-app bot removed the needs backport to 3.11 only security fixes label Dec 4, 2023
@chrstphrchvz chrstphrchvz deleted the patch-1 branch December 4, 2023 08:10
serhiy-storchaka pushed a commit that referenced this pull request Dec 4, 2023
…12679) (GH-112691)

(cherry picked from commit 23e001f)

Co-authored-by: Christopher Chavez <[email protected]>
serhiy-storchaka pushed a commit that referenced this pull request Dec 4, 2023
…12679) (GH-112690)

(cherry picked from commit 23e001f)

Co-authored-by: Christopher Chavez <[email protected]>
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants