gh-113157 gh-89519: Fix method descriptors #113233
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…escriptor chaining was introduced.
rhettinger
changed the title
|
I think there's a typo in the commit message, you probably meant to reference gh-113157 ? |
facebook-github-bot
pushed a commit
to facebookincubator/cinder
that referenced
this pull request
Dec 22, 2023
…ted since 3.11) Summary: backport upstream PRs python/cpython#110163 and python/cpython#113233 upstream issues: python/cpython#89519 (Calling help executes classmethod property decorated methods) and python/cpython#113157 (Changed behavior of <instancemethod>.__get__ in Python 3.11) upstream commits: [`7f9a99e8549b792662f2cd28bf38a4d4625bd402`](python/cpython@7f9a99e) and [`d058eaeed44766a8291013b275ad22f153935d3b`](python/cpython@d058eae) Reviewed By: aleivag Differential Revision: D52014322 fbshipit-source-id: 87de6d9587bd9cc49f053ca340adfc469b041f91
ryan-duve
pushed a commit
to ryan-duve/cpython
that referenced
this pull request
Dec 26, 2023
Restore behaviors before classmethod descriptor chaining was introduced.
kulikjak
pushed a commit
to kulikjak/cpython
that referenced
this pull request
Jan 22, 2024
Restore behaviors before classmethod descriptor chaining was introduced.
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
Restore behaviors before classmethod descriptor chaining was introduced.
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this pull request
Sep 2, 2024
Restore behaviors before classmethod descriptor chaining was introduced.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix yet another problem created by classmethod descriptor chaining. This completes the work in gh-89519, fixes the bug reported in gh-113157, and get us back to the stable and correct semantics in Python 3.9.
There is still an open question about what if anything to do for Python 3.11 and Python 3.12. We can' t backport this without breaking something else.