Skip to content

GH-113595: Don't enter invalid executor #113596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 3, 2024
Merged

GH-113595: Don't enter invalid executor #113596

merged 2 commits into from
Jan 3, 2024

Conversation

markshannon
Copy link
Member

@markshannon markshannon commented Dec 31, 2023 •
edited by bedevere-app bot
Loading

This PR checks if an executor is invalid before entering it.
If the executor is invalid, it cleans up the ENTER_EXECUTOR and executor.

@bedevere-app bedevere-app bot mentioned this pull request Dec 31, 2023
Closed
gvanrossum
gvanrossum approved these changes Dec 31, 2023
View reviewed changes
Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, makes sense.

@markshannon markshannon merged commit dc8df6e into python:main Jan 3, 2024
@markshannon markshannon deleted the dont-enter-invalid-executor branch January 3, 2024 13:15
@markshannon markshannon mentioned this pull request Jan 3, 2024
Merged
@brandtbucher brandtbucher mentioned this pull request Jan 4, 2024
Merged
kulikjak pushed a commit to kulikjak/cpython that referenced this pull request Jan 22, 2024
@markshannon @kulikjak
pythonGH-113595: Don't enter invalid executor (pythonGH-113596)
34c127d
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@markshannon @aisk
pythonGH-113595: Don't enter invalid executor (pythonGH-113596)
d180da6
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@markshannon @Glyphack
pythonGH-113595: Don't enter invalid executor (pythonGH-113596)
93a091c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@markshannon @gvanrossum