-
-
Notifications
You must be signed in to change notification settings - Fork 32.1k
gh-112050: Convert most methods on collections.deque to use Argument Clinic #113963
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 8 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
2f9c90a
Convert most collections.deque methods to use clinic
mpage 60b6346
Merge remote-tracking branch 'upstream/main' into ft-deque-clinic
mpage eefd994
📜🤖 Added by blurb_it.
blurb-it[bot] 991f686
Fix error in docstring for popleft
mpage 37c4c05
Make docstring for __init__ more closely resemble the original
mpage 35c16c2
Add missing periods in deque docstrings
mpage 875433b
Use consistent names for value params
mpage 3600a40
Drop the `_collections_`, it's cleaner
mpage b7bc0b2
Reuse existing argument names
mpage a306210
Merge branch 'main' into ft-deque-clinic
erlend-aasland 934fd2e
Update Misc/NEWS.d/next/Core and Builtins/2024-01-11-22-58-45.gh-issu…
erlend-aasland File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
1 change: 1 addition & 0 deletions
1
Misc/NEWS.d/next/Core and Builtins/2024-01-11-22-58-45.gh-issue-112050.hDuvDW.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
Convert most methods on collections.deque to use Argument Clinic. This is in preparation for making deques thread-safe when the GIL is disabled. To do so, we'll use Clinic's critical_section directive. | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.