gh-108303: Remove Lib/test/shadowed_super.py
#114372
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sobolevn
added
skip news
needs backport to 3.11
vstinner
reviewed
Jan 22, 2024
| """, | ||
| ) | ||
| with import_helper.ready_to_import(name="shadowed_super", source=source): | ||
| import shadowed_super | ||
| self.assertEqual(shadowed_super.C().method(), "truly super") |
There was a problem hiding this comment.
Would it be possible to unload the module explicitly after its usage? Use unload() of import_helper.
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jan 22, 2024
Move code into Lib/test/test_super.py. (cherry picked from commit 2ef520e) Co-authored-by: Nikita Sobolev <[email protected]>
|
Sorry, @sobolevn and @vstinner, I could not cleanly backport this to |
|
GH-114433 is a backport of this pull request to the 3.12 branch. |
|
There is no need to backport to 3.11: Lib/test/shadowed_super.py doesn't exist in the 3.11 branch. |
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
Move code into Lib/test/test_super.py.
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this pull request
Sep 2, 2024
Move code into Lib/test/test_super.py.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This support file was only used in a single test, there's no point in using it, really.
It can be replaced with a simple script.