gh-114807: multiprocessing: don't raise ImportError if _multiprocessing is missing #114808
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tiprocessing is missing _multiprocessing is only used under the `if _winapi` block so I think it makes sense to move the import behind the same try/catch block.
|
Thanks for the fix, you might want to add a news entry with https://blurb-it.herokuapp.com/. Otherwise LGTM |
|
This is a tiny change and I think people are unlikely to be interested, so probably no news entry is necessary? But I'm happy to add one if you think it's newsworthy. |
Jason-Y-Z
approved these changes
Feb 10, 2024
gpshead
approved these changes
Feb 11, 2024
fsc-eriker
pushed a commit
to fsc-eriker/cpython
that referenced
this pull request
Feb 14, 2024
…ocessing is missing (python#114808) `_multiprocessing` is only used under the `if _winapi:` block, this moves the import to be within the `_winapi` ImportError handling try/except for equivalent treatment.
ambv
pushed a commit
to ambv/cpython
that referenced
this pull request
Feb 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_multiprocessing is only used under the
if _winapiblock so I think it makes sense to move the import behind the same try/catch block.