Skip to content

gh-115249: Fix test_descr with -OO mode #115250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 11, 2024
Merged

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented Feb 10, 2024

Now it passes with both -00 and without.

@sobolevn sobolevn requested a review from vstinner February 10, 2024 15:59
@bedevere-app bedevere-app bot added the tests Tests in the Lib/test dir label Feb 10, 2024
@terryjreedy
Copy link
Member

terryjreedy commented Feb 10, 2024

The Windows 86 free-threading failure in test_queue (timeout) is an independent failure reported in ##115258. Since the same passed on another of your PRs, I triggered a one-test rerun.

Copy link
Member

@terryjreedy terryjreedy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the proper fix for a buggy test.

@sobolevn sobolevn added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Feb 11, 2024
@sobolevn sobolevn merged commit 1f23837 into python:main Feb 11, 2024
@miss-islington-app
Copy link

Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 11, 2024
(cherry picked from commit 1f23837)

Co-authored-by: Nikita Sobolev <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Feb 11, 2024

GH-115277 is a backport of this pull request to the 3.12 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 11, 2024
(cherry picked from commit 1f23837)

Co-authored-by: Nikita Sobolev <[email protected]>
@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Feb 11, 2024
@bedevere-app
Copy link

bedevere-app bot commented Feb 11, 2024

GH-115278 is a backport of this pull request to the 3.11 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.11 only security fixes label Feb 11, 2024
sobolevn added a commit that referenced this pull request Feb 11, 2024
gh-115249: Fix `test_descr` with `-OO` mode (GH-115250)
(cherry picked from commit 1f23837)

Co-authored-by: Nikita Sobolev <[email protected]>
sobolevn added a commit that referenced this pull request Feb 11, 2024
gh-115249: Fix `test_descr` with `-OO` mode (GH-115250)
(cherry picked from commit 1f23837)

Co-authored-by: Nikita Sobolev <[email protected]>
@vstinner
Copy link
Member

Congrats @sobolevn for your first merge as a Python core dev! 🎉

fsc-eriker pushed a commit to fsc-eriker/cpython that referenced this pull request Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants