Skip to content

gh-114058: Improve method information in redundancy eliminator #115848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 23, 2024

Conversation

Fidget-Spinner
Copy link
Member

@Fidget-Spinner Fidget-Spinner commented Feb 23, 2024

@Fidget-Spinner
Copy link
Member Author

Addresses @markshannon 's reviews in #115779 (comment).

Copy link
Member

@markshannon markshannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think you can remove sym_is_not_null

@bedevere-app
Copy link

bedevere-app bot commented Feb 23, 2024

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

@Fidget-Spinner
Copy link
Member Author

I have made the requested changes; please review again

Copy link
Member

@markshannon markshannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@Fidget-Spinner Fidget-Spinner merged commit 2ec50b4 into python:main Feb 23, 2024
@Fidget-Spinner Fidget-Spinner deleted the improve_methods branch February 23, 2024 15:41
woodruffw pushed a commit to woodruffw-forks/cpython that referenced this pull request Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants