Skip to content

gh-116010: Remove link to deprecated PEP 6 in FAQ guide #116246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 3, 2024
Merged

gh-116010: Remove link to deprecated PEP 6 in FAQ guide #116246

merged 5 commits into from
Mar 3, 2024

Conversation

Tabrizian
Copy link
Contributor

@Tabrizian Tabrizian commented Mar 2, 2024 •
edited by hugovk
Loading

Remove link to deprecated PEP 6 in FAQ guide.

I looked for other mentions of PEP 6. I only found mentions in the translated docs.

Closes: #116010

📚 Documentation preview 📚: https://cpython-previews--116246.org.readthedocs.build/en/116246/faq/general.html#how-does-the-python-version-numbering-scheme-work

@bedevere-app bedevere-app bot mentioned this pull request Mar 2, 2024
Closed
@bedevere-app bedevere-app bot added docs Documentation in the Doc dir skip news labels Mar 2, 2024
hugovk
hugovk reviewed Mar 2, 2024
View reviewed changes
@Tabrizian @hugovk
Apply suggestion
64cd2cf 
Co-authored-by: Hugo van Kemenade <[email protected]>
@Tabrizian Tabrizian requested a review from hugovk March 2, 2024 17:17
@hugovk
Copy link
Member

hugovk commented Mar 2, 2024

Thanks!

One last thought, this changed section is in the middle:

image

Shall we move it to the last paragraph?

Something like:

See the Developer’s Guide for more information about the development cycle, and PEP 387 to learn more about Python’s backward compatibility policy. See also the documentation for sys.version, sys.hexversion, and sys.version_info.

@hugovk hugovk added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Mar 2, 2024
hugovk
hugovk reviewed Mar 2, 2024
View reviewed changes
@Tabrizian Tabrizian requested review from hugovk March 2, 2024 20:25
hugovk
hugovk reviewed Mar 3, 2024
View reviewed changes
@Tabrizian @hugovk
Update Doc/faq/general.rst
3a572cc 
Co-authored-by: Hugo van Kemenade <[email protected]>
hugovk
hugovk approved these changes Mar 3, 2024
View reviewed changes
Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, thank you!

@Tabrizian
Copy link
Contributor Author

@hugovk Thanks for the review and feedback! Do you know who can help get this PR merged in?

@hugovk
Copy link
Member

hugovk commented Mar 3, 2024

I can merge! I'll do it later today in case no-one else pops in with a review! 👍

@hugovk hugovk merged commit 3383d6a into python:main Mar 3, 2024
@miss-islington-app
Copy link

Thanks @Tabrizian for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 3, 2024
@Tabrizian @hugovk @miss-islington
pythongh-116010: Remove link to deprecated PEP 6 in FAQ guide (python…
21bc094 
…GH-116246)

(cherry picked from commit 3383d6a)

Co-authored-by: Iman Tabrizian <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 3, 2024
@Tabrizian @hugovk @miss-islington
pythongh-116010: Remove link to deprecated PEP 6 in FAQ guide (python…
0d32825 
…GH-116246)

(cherry picked from commit 3383d6a)

Co-authored-by: Iman Tabrizian <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Mar 3, 2024

GH-116286 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Mar 3, 2024
@bedevere-app
Copy link

bedevere-app bot commented Mar 3, 2024

GH-116287 is a backport of this pull request to the 3.11 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.11 only security fixes label Mar 3, 2024
@hugovk
Copy link
Member

hugovk commented Mar 3, 2024

Thanks again!

hugovk added a commit that referenced this pull request Mar 3, 2024
@miss-islington @Tabrizian @hugovk
[3.11] gh-116010: Remove link to deprecated PEP 6 in FAQ guide (GH-11…
6c2484b 
…6246) (#116287)

Co-authored-by: Iman Tabrizian <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
hugovk added a commit that referenced this pull request Mar 3, 2024
@miss-islington @Tabrizian @hugovk
[3.12] gh-116010: Remove link to deprecated PEP 6 in FAQ guide (GH-11…
722b9cf 
…6246) (#116286)

Co-authored-by: Iman Tabrizian <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
@Tabrizian Tabrizian deleted the imant-pep6 branch March 3, 2024 20:22
woodruffw pushed a commit to woodruffw-forks/cpython that referenced this pull request Mar 4, 2024
@Tabrizian @hugovk @woodruffw
pythongh-116010: Remove link to deprecated PEP 6 in FAQ guide (python…
73fed2a 
…#116246)

Co-authored-by: Hugo van Kemenade <[email protected]>
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 25, 2024
@Tabrizian @hugovk @adorilson
pythongh-116010: Remove link to deprecated PEP 6 in FAQ guide (python…
9b4f007 
…#116246)

Co-authored-by: Hugo van Kemenade <[email protected]>
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
@Tabrizian @hugovk @diegorusso
pythongh-116010: Remove link to deprecated PEP 6 in FAQ guide (python…
795b24a 
…#116246)

Co-authored-by: Hugo van Kemenade <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugovk hugovk hugovk approved these changes

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FAQ: Replace PEP 6 link with devguide
2 participants
@Tabrizian @hugovk