Skip to content

gh-116491: Improve test_win32_ver #116506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sobolevn merged 2 commits into from
Mar 13, 2024
Merged

gh-116491: Improve test_win32_ver #116506

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8001a10
gh-116491: Improve `test_win32_ver`
sobolevn Mar 8, 2024
9345789
Address review
sobolevn Mar 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions Lib/test/test_platform.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -328,6 +328,27 @@ def test_java_ver(self):

def test_win32_ver(self):
res = platform.win32_ver()
self.assertEqual(len(res), 4)
if support.MS_WINDOWS:
release, version, csd, ptype = res
if release:
releases = []
releases.extend(r for _k, r in platform._WIN32_CLIENT_RELEASES)
releases.extend(r for _k, r in platform._WIN32_SERVER_RELEASES)
self.assertIn(release, releases)
if version:
# It is rather hard to test explicit version without
# going deep into the details.
self.assertIn('.', version)
if csd:
self.assertTrue(csd.startswith('SP'), msg=csd)
if ptype:
if os.cpu_count() > 1:
self.assertIn('Multiprocessor', ptype)
else:
self.assertIn('Uniprocessor', ptype)
else:
self.assertTrue(all(part == '' for part in res), msg=res)

def test_mac_ver(self):
res = platform.mac_ver()
Expand Down