-
-
Notifications
You must be signed in to change notification settings - Fork 31.8k
gh-113317: Add libclinic.block_parser and libclinic.language modules #116819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
vstinner
commented
Mar 14, 2024
•
edited by bedevere-app
bot
Loading
edited by bedevere-app
bot
- Move Block and BlockParser classes to a new libclinic.block_parser module.
- Move Language and PythonLanguage classes to a new libclinic.language module.
- Issue: Argument Clinic: split out global stateless helpers and constants from clinic.py #113317
* Move Block and BlockParser classes to a new libclinic.block_parser module. * Move Language and PythonLanguage classes to a new libclinic.language module.
Would it not be better to create a |
Instead of
Now, we suddenly have C language stuff scattered over two submodules: |
Should |
I started with very small files to break inter-dependencies, otherwise it's not possible to move any line of code. Once more more will live in libclinic, it will be easier to move related code together. CLanguage should live in its on own file, right. |
BlockParser creates Block, so they are related, no?
I didn't manage to move it yet. But I would prefer to separate parsing code and code genereration code in different files, if possible. |
Yes, this is something we've been discussing. How about putting the intermediate representation ( |
* Move Block and BlockParser classes to a new libclinic.block_parser module. * Move Language and PythonLanguage classes to a new libclinic.language module.
* Move Block and BlockParser classes to a new libclinic.block_parser module. * Move Language and PythonLanguage classes to a new libclinic.language module.
* Move Block and BlockParser classes to a new libclinic.block_parser module. * Move Language and PythonLanguage classes to a new libclinic.language module.