gh-113317: Rename libclinic to argclinic #117533
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
vstinner
commented
Apr 4, 2024
•
vstinner
commented
- Rename Tools/clinic/libclinic/ to Tools/clinic/argclinic/
- Rename Tools/clinic/clinic.py to Tools/clinic/run_argclinic.py.
- Add Tools/clinic/argclinic/main.py.
- Convert absolute imports to imports related to the packages. For example, replace "from libclinic.cli import main" with "from .cli import main".
- Remove "import clinic": import individual names.
- "make clinic" now runs "python -m clinic".
- Issue: Argument Clinic: split out global stateless helpers and constants from clinic.py #113317
* Rename Tools/clinic/libclinic/ to Tools/clinic/argclinic/ * Rename Tools/clinic/clinic.py to Tools/clinic/run_argclinic.py. * Add Tools/clinic/argclinic/__main__.py. * Convert absolute imports to imports related to the packages. For example, replace "from libclinic.cli import main" with "from .cli import main". * Remove "import clinic": import individual names. * "make clinic" now runs "python -m clinic".
|
@erlend-aasland: Here is a proposition to replace I also renamed "clinic" to "argclinic" to have a more specific name (be more explicit about the reference to the Monty Python sketch). The PR is a little bit bigger than expect since there were still a few files importing |
|
What is the rationale for this change? |
My long term goal is to distribute Argument Clinic on PyPI. But I know that you disagree with that. I prefer to close this PR for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.