Skip to content

gh-117649: Fix file descriptor leak in (expected) failing test case #117780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

colesbury
Copy link
Contributor

@colesbury colesbury commented Apr 11, 2024

The test case is currently expected to fail in the free-threaded build. However, it fails before it gets a chance to close the write end of the pipe.

…case

The test case is currently expected to fail in the free-threaded build.
However, it fails before it gets a chance to close the write end of
the pipe.
@colesbury colesbury added tests Tests in the Lib/test dir skip news labels Apr 11, 2024
@colesbury colesbury added 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section and removed awaiting core review labels Apr 11, 2024
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @colesbury for commit 82ceef0 🤖

If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again.

Copy link
Member

@ericsnowcurrently ericsnowcurrently left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@colesbury colesbury enabled auto-merge (squash) April 11, 2024 21:05
@colesbury colesbury merged commit 1b10efa into python:main Apr 11, 2024
42 of 46 checks passed
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
…case (python#117780)

The test case is currently expected to fail in the free-threaded build.
However, it fails before it gets a chance to close the write end of
the pipe.
@colesbury colesbury deleted the gh-117649-fd-leak branch April 19, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants