Skip to content

gh-117755: Skip test_io.test_constructor() on s390x #117801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 15, 2024

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Apr 12, 2024

The test allocates 9 223 372 036 854 775 807 bytes (0x7fffffffffffffff) and mimalloc fails with a division by zero on s390x.

The test allocates 9 223 372 036 854 775 807 bytes
(0x7fffffffffffffff) and mimalloc fails with a division by zero on
s390x.
@vstinner
Copy link
Member Author

This is a bug in mimalloc. We already worked around a similar (but different) bug in test_decimal by skipping the test: see issue gh-114331. I will try investigate the mimalloc issue later, but I prefer to skip the test for now to unblock my colleague @befeleme with Python 3.13 alpha6.

@hroncok
Copy link
Contributor

hroncok commented Apr 12, 2024

...to unblock my colleague @befeleme with Python 3.13 alpha6.

For clarification, we (me and @befeleme) are not blocked on this. The freethreding build in Fedora is disabled on s390x and we can keep it that way for now.

@vstinner
Copy link
Member Author

For clarification, we (me and @befeleme) are not blocked on this. The freethreding build in Fedora is disabled on s390x and we can keep it that way for now.

As the s390x maintainer in Python, I would prefer that you test it to discover real bugs like these ones :-)

@vstinner
Copy link
Member Author

This change is a workaround.

I wrote a fix for the root issue in mimalloc: PR gh-117809.

@vstinner vstinner merged commit a9107fe into python:main Apr 15, 2024
34 checks passed
@vstinner vstinner deleted the test_io_s390X branch April 15, 2024 08:24
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 FreeBSD14 3.x has failed when building commit a9107fe.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/1232/builds/1984) and take a look at the build logs.
  4. Check if the failure is related to this commit (a9107fe) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/1232/builds/1984

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last):
  File "<frozen getpath>", line 352, in <module>
ValueError: embedded null byte
Warning -- Uncaught thread exception: InterpreterError
Exception in thread Thread-57 (task):
RuntimeError: error evaluating path


Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.opsec-fbsd14/build/Lib/threading.py", line 1039, in _bootstrap_inner
    self.run()
    ~~~~~~~~^^
  File "/home/buildbot/buildarea/3.x.opsec-fbsd14/build/Lib/threading.py", line 990, in run
    self._target(*self._args, **self._kwargs)
    ~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/buildbot/buildarea/3.x.opsec-fbsd14/build/Lib/test/test_interpreters/test_stress.py", line 29, in task
    interp = interpreters.create()
             ~~~~~~~~~~~~~~~~~~~^^
  File "/home/buildbot/buildarea/3.x.opsec-fbsd14/build/Lib/test/support/interpreters/__init__.py", line 76, in create
    id = _interpreters.create(reqrefs=True)
         ~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^
interpreters.InterpreterError: interpreter creation failed
k


Traceback (most recent call last):
  File "<frozen getpath>", line 462, in <module>
ValueError: embedded null byte
Warning -- Uncaught thread exception: InterpreterError
Exception in thread Thread-100 (task):
RuntimeError: error evaluating path

diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
)

The test allocates 9 223 372 036 854 775 807 bytes
(0x7fffffffffffffff) and mimalloc fails with a division by zero on
s390x.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants