Skip to content

gh-112278: Improve error handling in wmi module and tests #117818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 15, 2024
Merged

gh-112278: Improve error handling in wmi module and tests #117818

merged 1 commit into from
Apr 15, 2024

Conversation

zooba
Copy link
Member

@zooba zooba commented Apr 12, 2024 •
edited by bedevere-app bot
Loading

@zooba zooba requested a review from a team as a code owner April 12, 2024 13:22
@bedevere-app bedevere-app bot mentioned this pull request Apr 12, 2024
Closed
@zooba
Copy link
Member Author

zooba commented Apr 12, 2024

!buildbot .windows.

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @zooba for commit 0082704 🤖

The command will test the builders whose names match following regular expression: .*windows.*

The builders matched are:

  • AMD64 Windows11 Bigmem PR
  • AMD64 Windows11 Non-Debug PR
  • ARM64 Windows PR
  • ARM64 Windows Non-Debug PR
  • AMD64 Windows10 PR
  • AMD64 Windows Server 2022 NoGIL PR
  • AMD64 Windows11 Refleaks PR

@zooba zooba mentioned this pull request Apr 12, 2024
Merged
@zooba zooba self-assigned this Apr 12, 2024
@aisk
Copy link
Contributor

aisk commented Apr 13, 2024

This change looks good to me except for the nitpick mentioned above. I tested it on my local machine and it passed.

But there were 3 changes to this file before, which haven't been backported to 3.12 yet, so I think Miss Islington will have trouble backporting this change. Should we just manually backport this change by pasting the whole file like you mentioned before in the original issue?

@zooba
Copy link
Member Author

zooba commented Apr 15, 2024

Yeah, I expect this to require a manual backport. I'll update the entire file when I do it.

@zooba zooba merged commit 7d9d6b5 into python:main Apr 15, 2024
44 of 45 checks passed
@miss-islington-app
Copy link

Thanks @zooba for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Sorry, @zooba, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 7d9d6b53bcee58252e38732a1fa1ca786eba4aab 3.12

@zooba zooba deleted the gh-112278 branch April 15, 2024 14:43
zooba added a commit to zooba/cpython that referenced this pull request Apr 15, 2024
@zooba
pythongh-112278: Improve error handling in wmi module and tests (pyth…
4db816d 
…onGH-117818)
@bedevere-app
Copy link

bedevere-app bot commented Apr 15, 2024

GH-117899 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Apr 15, 2024
zooba added a commit that referenced this pull request Apr 15, 2024
@zooba
gh-112278: Improve error handling in wmi module and tests (GH-117818)
667a574
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
@zooba @diegorusso
pythongh-112278: Improve error handling in wmi module and tests (pyth…
de622c3 
…onGH-117818)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aisk aisk aisk left review comments

Assignees

@zooba zooba

Labels
OS-windows skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zooba @bedevere-bot @aisk