-
-
Notifications
You must be signed in to change notification settings - Fork 31.9k
[3.12] gh-71966: Move the module docstring from _pydecimal to decimal (GH-117919) #117962
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3.12] gh-71966: Move the module docstring from _pydecimal to decimal (GH-117919) #117962
Conversation
…ythonGH-117919) Now it is set even if the C implementation is used. Also add a one-line synopsis. (cherry picked from commit c69968f) Co-authored-by: Serhiy Storchaka <[email protected]>
This change has broken sequential test running (and thus the 3.12.4 release):
I believe it's because the (new) decimal.py docstring fiddles with the default context. Making the docstring restore the context fixes the other test failures, but causes decimal's class doctests to fail:
@serhiy-storchaka do you have time to look at this today? (I'm in California right now and it's evening already, so unless there's an obvious quick fix I'm overlooking I'll have to delay the 3.12.4 release by another day anyway.) |
(Rolling back may also be an option?) |
It is strange that this only affects 3.12. For now I have not found anything in the difference between 3.12 and 3.13 in _pydecimal, test_decimal, libregrtest, unittest and doctest that could explain this. This only happens with the C implementation of decimal. P.S. I finally found how to fix this (see #120147), but I have no idea why is this only needed in 3.12. |
Now it is set even if the C implementation is used.
Also add a one-line synopsis.
(cherry picked from commit c69968f)
Co-authored-by: Serhiy Storchaka [email protected]