Skip to content

gh-116935: Document that heap types need to support garbage collection #118021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Apr 19, 2024
Merged

gh-116935: Document that heap types need to support garbage collection #118021

merged 8 commits into from
Apr 19, 2024

Conversation

savannahostrowski
Copy link
Member

@savannahostrowski savannahostrowski commented Apr 18, 2024 •
edited by encukou
Loading

@bedevere-app bedevere-app bot mentioned this pull request Apr 18, 2024
Closed
@bedevere-app bedevere-app bot added docs Documentation in the Doc dir skip news awaiting review labels Apr 18, 2024
@encukou
Copy link
Member

encukou commented Apr 18, 2024

Thank you for the addition!
Could you please add a link to Supporting Cyclic Garbage Collection, so readers can learn about the details if they don't already know them?

@savannahostrowski savannahostrowski mentioned this pull request Apr 19, 2024
Merged
JelleZijlstra
JelleZijlstra approved these changes Apr 19, 2024
View reviewed changes
Copy link
Member

@JelleZijlstra JelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The wording looks good but I'd like another review from someone who is more familiar with the C API.

kalebers
kalebers approved these changes Apr 19, 2024
View reviewed changes
Copy link

@kalebers kalebers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done, thanks for adding helpful information!

encukou
encukou reviewed Apr 19, 2024
View reviewed changes
@encukou encukou enabled auto-merge (squash) April 19, 2024 09:01
@encukou encukou added the needs backport to 3.12 only security fixes label Apr 19, 2024
@encukou encukou merged commit 5d54436 into python:main Apr 19, 2024
26 checks passed
@miss-islington-app
Copy link

Thanks @savannahostrowski for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 19, 2024
@savannahostrowski @miss-islington
pythongh-116935: Document that heap types need to support garbage col…
286137a 
…lection (pythonGH-118021)

(cherry picked from commit 5d54436)

Co-authored-by: Savannah Ostrowski <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Apr 19, 2024

GH-118092 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Apr 19, 2024
encukou pushed a commit that referenced this pull request Apr 19, 2024
@miss-islington @savannahostrowski
[3.12] gh-116935: Document that heap types need to support garbage co…
f278b8f 
…llection (GH-118021) (GH-118092)

gh-116935: Document that heap types need to support garbage collection (GH-118021)
(cherry picked from commit 5d54436)

Co-authored-by: Savannah Ostrowski <[email protected]>
@savannahostrowski
Copy link
Member Author

Thanks for the reviews, folks!

@savannahostrowski savannahostrowski deleted the fix-116935 branch September 27, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@encukou encukou encukou approved these changes

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

@kalebers kalebers kalebers approved these changes

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

docs(easy): Document that heap types need to support garbage collection
4 participants
@savannahostrowski @encukou @JelleZijlstra @kalebers