Skip to content

gh-112730: use keyword only argument for colorize #118086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

gh-112730: use keyword only argument for colorize #118086

wants to merge 1 commit into from
+10 −18

Conversation

methane
Copy link
Member

@methane methane commented Apr 19, 2024 •
edited by bedevere-app bot
Loading

@methane methane requested a review from pablogsal April 19, 2024 07:19
@methane methane requested a review from iritkatriel as a code owner April 19, 2024 07:19
@bedevere-app bedevere-app bot mentioned this pull request Apr 19, 2024
Closed
@methane
Copy link
Member Author

methane commented Apr 19, 2024

sorry if there is a reason to use kwargs.

@methane
Copy link
Member Author

methane commented Apr 19, 2024

Maybe, you don't want to expose this option as public API.

@methane methane closed this Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablogsal pablogsal Awaiting requested review from pablogsal

@iritkatriel iritkatriel Awaiting requested review from iritkatriel

Assignees
No one assigned
Labels
awaiting core review skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@methane