gh-118433: Temporarily skip test_interrupt_main_subthread in free-threaded builds
#118485
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Free-threaded builds can intermittently tickle a longstanding bug (24 years!) in the implementation of `threading.Condition`, leading to flakiness in the test suite. Fixing the underlying issue will require more discussion, and will likely apply to most of the concurrency primitives in the `threading` module that are written in Python. See pythongh-118433 for more details. Disable the test in free-threaded builds as a temporary measure to eliminate flakiness.
|
!buildbot M1 Refleaks NoGIL |
|
🤖 New build scheduled with the buildbot fleet by @colesbury for commit de8ab42 🤖 The command will test the builders whose names match following regular expression: The builders matched are:
|
|
@brandtbucher is seeing repeated failures of this test on the Windows GitHub actions CI (https://github.com/python/cpython/actions/runs/8912122661/job/24481577797?pr=118481) so I'm going to enable auto-merge now. |
|
@colesbury - Isn't that a different test ( |
|
Well, that's doubly embarrassing... |
SonicField
pushed a commit
to SonicField/cpython
that referenced
this pull request
May 8, 2024
…free-threaded builds (python#118485) Free-threaded builds can intermittently tickle a longstanding bug (24 years!) in the implementation of `threading.Condition`, leading to flakiness in the test suite. Fixing the underlying issue will require more discussion, and will likely apply to most of the concurrency primitives in the `threading` module that are written in Python. See pythongh-118433 for more details.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Free-threaded builds can intermittently tickle a longstanding bug (24 years!) in the implementation of
threading.Condition, leading to flakiness in the test suite. Fixing the underlying issue will require more discussion, and will likely apply to most of the concurrency primitives in thethreadingmodule that are written in Python. See gh-118433 for more details.Disable the test in free-threaded builds as a temporary measure to eliminate flakiness.