Skip to content

GH-118095: Make BINARY_SUBSCR_GETITEM suitable for tier 2 #120793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Aug 1, 2024
Merged

GH-118095: Make BINARY_SUBSCR_GETITEM suitable for tier 2 #120793

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
392c520
Make BINARY_SUBSCR_GETITEM suitable for tier 2
markshannon Jun 20, 2024
2af2a91
Add guard for code object when projecting traces through calls
markshannon Jun 20, 2024
4948eb1
Don't project through _PUSH_FRAME in BINARY_SUBSCR_GETITEM
markshannon Jun 21, 2024
75bdac3
Fix typo
markshannon Jun 21, 2024
cde0f02
Refactor BINARY_SUBSCR_GETITEM to use less stack space
markshannon Jun 25, 2024
138cd41
Be more consistent about what terminates a trace in the optimizer
markshannon Jun 25, 2024
8ea721e
fix whitespace
markshannon Jun 25, 2024
2b7cd34
Merge branch 'main' into binary-subscr-getitem-tier-2
markshannon Jul 18, 2024
71920f1
Merge branch 'main' into binary-subscr-getitem-tier-2
markshannon Jul 30, 2024
da2671e
Revert "Add guard for code object when projecting traces through calls"
brandtbucher Aug 1, 2024
d4df441
typo
brandtbucher Aug 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Include/internal/pycore_opcode_metadata.h
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 10 additions & 0 deletions Include/internal/pycore_optimizer.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,6 +259,16 @@ PyAPI_FUNC(PyObject *) _Py_uop_symbols_test(PyObject *self, PyObject *ignored);

PyAPI_FUNC(int) _PyOptimizer_Optimize(struct _PyInterpreterFrame *frame, _Py_CODEUNIT *start, _PyStackRef *stack_pointer, _PyExecutorObject **exec_ptr);

static inline int is_terminator(const _PyUOpInstruction *uop)
{
int opcode = uop->opcode;
return (
opcode == _EXIT_TRACE ||
opcode == _JUMP_TO_TOP ||
opcode == _DYNAMIC_EXIT
);
}

#ifdef __cplusplus
}
#endif
Expand Down
Loading
Loading