-
-
Notifications
You must be signed in to change notification settings - Fork 31.9k
Refactor test_capi.test_long #122113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor test_capi.test_long #122113
Conversation
Share common code for tests for PyLong_As*() functions. Co-authored-by: Victor Stinner <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
Share common code for tests for PyLong_As*() functions. (cherry picked from commit 69f2dc5) Co-authored-by: Serhiy Storchaka <[email protected]> Co-authored-by: Victor Stinner <[email protected]>
GH-122137 is a backport of this pull request to the 3.13 branch. |
Sorry, @serhiy-storchaka, I could not cleanly backport this to
|
Thank you, Victor. |
Share common code for tests for PyLong_As*() functions. (cherry picked from commit 69f2dc5) Co-authored-by: Serhiy Storchaka <[email protected]> Co-authored-by: Victor Stinner <[email protected]>
Share common code for tests for PyLong_As*() functions. (cherry picked from commit 69f2dc5) Co-authored-by: Serhiy Storchaka <[email protected]> Co-authored-by: Victor Stinner <[email protected]>
GH-122151 is a backport of this pull request to the 3.12 branch. |
Share common code for tests for PyLong_As*() functions. (cherry picked from commit 69f2dc5) Co-authored-by: Victor Stinner <[email protected]>
Share common code for tests for PyLong_As*() functions.
Based on test changes in #120390. The same helper is used in tests for all signed and unsigned integer types.
negative_value_error
is now an exception class, not a boolean.