GH-122155: Fix cases generator to correctly compute 'peek' offset for error handling #122158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iritkatriel
approved these changes
Jul 23, 2024
|
There's a mypy error, but otherwise LGTM. |
|
Thanks @markshannon for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
|
Sorry, @markshannon, I could not cleanly backport this to |
markshannon
added a commit
to faster-cpython/cpython
that referenced
this pull request
Jul 23, 2024
…et for error handling (pythonGH-122158)
|
GH-122174 is a backport of this pull request to the 3.13 branch. |
nohlson
pushed a commit
to nohlson/cpython
that referenced
this pull request
Jul 24, 2024
…et for error handling (pythonGH-122158)
nohlson
pushed a commit
to nohlson/cpython
that referenced
this pull request
Jul 24, 2024
…et for error handling (pythonGH-122158)
markshannon
added a commit
that referenced
this pull request
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Computes the "peek" offset on demand, rather than attempting to keep it up to date as the stack is modified.
This is simpler and less error prone.
I'll like to backport this to 3.13, so that the fix for #122029 can be more easily backported.