-
-
Notifications
You must be signed in to change notification settings - Fork 31.8k
gh-122885: Improve os.scandir (and os.walk) performance on Windows #122886
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
gh-122885: Improve os.scandir (and os.walk) performance on Windows #122886
Conversation
The following commit authors need to sign the Contributor License Agreement: |
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
2 similar comments
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
1dcb84b
to
417df7f
Compare
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
when I tried this patchset just now, I'm seeing a severe performance degradation. This could of course be due to some particularities of my rig, so I'll include all the relevant details I can think of.
when testing a real-world application, a webserver which uses scandir:
when doing a similar test with oha against my environment is windows 10 ltsc (version 1809, build 17763.5576), and I built cpython with VS-buildtools 2019 v16.11.37 using build.bat (no arguments) the folder I'm listing is cpython\PCbuild after building, so 132 files and 6 dirs |
Improve os.scandir (and os.walk) performance on Windows
Use native NT syscalls to implement os.scandir rather than WinAPI and POSIX functions.