Skip to content

GH-118093: Specialize CALL_FUNCTION_EX #123034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

GH-118093: Specialize CALL_FUNCTION_EX #123034

wants to merge 7 commits into from
+1,097 −732

Conversation

markshannon
Copy link
Member

@markshannon markshannon commented Aug 15, 2024 •
edited by bedevere-app bot
Loading

Adds two specializations of CALL_FUNCTION_EX:

  • CALL_FUNCTION_EX_PY for Python functions
  • CALL_FUNCTION_EX_NON_PY for everything else

@bedevere-app bedevere-app bot mentioned this pull request Aug 15, 2024
Open
3 tasks
@markshannon
Copy link
Member Author

markshannon commented Aug 15, 2024 •
edited
Loading

Shows a ~1% slowdown on tier 1, which is a bit surprising.
I'll need to investigate that before we can merge this.

@markshannon markshannon marked this pull request as draft August 15, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner

@iritkatriel iritkatriel Awaiting requested review from iritkatriel iritkatriel is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@markshannon