gh-111201: fix auto-indent in pyrepl for muliple pound comments #123196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pablogsal
approved these changes
Sep 3, 2024
pablogsal
added
awaiting review
needs backport to 3.13
auto-merge was automatically disabled
September 3, 2024 12:46
Pull request was closed
|
Thanks @wiggin15 for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 6, 2024
…pythonGH-123196) (cherry picked from commit d683f49) Co-authored-by: Arnon Yaari <[email protected]>
|
GH-123764 is a backport of this pull request to the 3.13 branch. |
ambv
pushed a commit
that referenced
this pull request
Sep 6, 2024
GH-123196) (GH-123764) (cherry picked from commit d683f49) Co-authored-by: Arnon Yaari <[email protected]>
This was referenced Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes an issue where a line that contains a control flow statement (if, for, ..) but ends with a comment that starts with multiple "#" signs, will not auto-indent the next line.
This happened because
last_charcould be updated to one of the "#" signs, missing the actual last character before the comment.