Remove comment from pystate created in 2003 #123259
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If this check needs to be kept, does this mean that the following |
That code is unreachable, so yes |
hauntsaninja
approved these changes
Aug 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a very minor change, but in pystate there's a check that thread state shouldn't be null when releasing the GIL.
This is a very useful check. If someone accidentally calls release GIL and didn't acquire the GIL from a native thread in an embedded Python scenario, they get this helpful fatal error message because there is no thread state.
I noticed there is a TODO above this check speculating that it isn't required dating back to 2003.
It is required because it avoids a crash and null lookup.
This PR removes the comment.