gh-123228: don't leak file descriptors in pyrepl test #123302
Conversation
if no f_in and f_out arguments are given, _ReadlineWrapper calls os.dup on fd 0 and 1. Instead, just pass None, because the fds aren't needed anyway in this test
hauntsaninja
added
🔨 test-with-buildbots
|
🤖 New build scheduled with the buildbot fleet by @hauntsaninja for commit 20eb346 🤖 If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again. |
bedevere-bot
removed
the
🔨 test-with-buildbots
hauntsaninja
added
the
🔨 test-with-refleak-buildbots
|
🤖 New build scheduled with the buildbot fleet by @hauntsaninja for commit 20eb346 🤖 If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again. |
bedevere-bot
removed
the
🔨 test-with-refleak-buildbots
|
ok, the refleak builds worked, the failures look unrelated. @hauntsaninja, I don't know what the usual approach is in such a situation? the commit definitely improves the buildbot situation. |
Let's land it and back port it |
|
Thanks @cfbolz for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13. |
…-123302) (cherry picked from commit aa90592) Co-authored-by: CF Bolz-Tereick <[email protected]>
|
GH-123313 is a backport of this pull request to the 3.13 branch. |
|
@pablogsal thank you! |
if no f_in and f_out arguments are given, _ReadlineWrapper calls os.dup on fd 0 and 1. Instead, just pass None, because the fds aren't needed anyway in this test.
str, not abytesobject #123228