Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gh-107954, PEP 741: Add PyConfig_Get() function #123472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-107954, PEP 741: Add PyConfig_Get() function #123472
Changes from all commits
4c79a52
988dca5
2d592a6
4e0951e
edc9974
4616b52
135d862
2324465
0c20c8a
67210db
262738f
fcf0918
a39857e
2014c52
4a3595c
8c321f1
1556b95
b655e93
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does it mean to be an invalid value? is it when it's NULL?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For example, pass a negative number when a bool is expected.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IIRC you accept >= 0 for bools but not < 0 right? maybe this could be added in the docs (maybe add something after the
bool
bullet point saying that anything >= 0 is considered as boolean but not <= 0?):The object type depends on the configuration option. It can be: * ``bool`` (nonnegative integer)
Something like that?