Skip to content

gh-123418: Update Android build to use OpenSSL 3.0.15 #123685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

zware
Copy link
Member

@zware zware commented Sep 4, 2024

Note: this will require an update to https://github.com/beeware/cpython-android-source-deps to add an openssl 3.0.15-0 release before this will actually build. (cc @freakboy3742, @mhsmith)

@zware zware added type-security A security issue topic-SSL dependencies Pull requests that update a dependency file OS-android needs backport to 3.13 bugs and security fixes labels Sep 4, 2024
@freakboy3742
Copy link
Contributor

@zware Seen; I'll poke the computermachine to get a new OpenSSL build.

As a bigger picture issue, I think it would be desirable to decouple the specific binary versions from the Android sources. This means there's a marginally more complex startup process for new developers as the full set of dependencies won't be auto-downloaded - but "download requirements before building" isn't an especially unusual or onerous requirement for building from source.

@freakboy3742
Copy link
Contributor

Android build of OpenSSL 3.0.15 has been published.

@freakboy3742 freakboy3742 marked this pull request as ready for review September 4, 2024 22:29
@zware zware merged commit 1fdfce9 into python:main Sep 4, 2024
42 checks passed
@zware zware deleted the bump_android_openssl_3.0.15 branch September 4, 2024 22:43
@miss-islington-app
Copy link

Thanks @zware for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 4, 2024
@bedevere-app
Copy link

bedevere-app bot commented Sep 4, 2024

GH-123715 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Sep 4, 2024
freakboy3742 pushed a commit that referenced this pull request Sep 4, 2024
…) (#123715)

gh-123418: Update Android build to use OpenSSL 3.0.15 (GH-123685)
(cherry picked from commit 1fdfce9)

Co-authored-by: Zachary Ware <[email protected]>
@mhsmith
Copy link
Member

mhsmith commented Sep 13, 2024

I think it would be desirable to decouple the specific binary versions from the Android sources.

I think it's worth keeping a set of known-good versions in the build script, but it's actually pretty easy to use different ones if you want. All you have to do is create the prefix directory and put your own builds in it. As long as that directory exists, the script won't download the dependencies automatically.

@freakboy3742
Copy link
Contributor

I think it would be desirable to decouple the specific binary versions from the Android sources.

I think it's worth keeping a set of known-good versions in the build script,

The downside is that every time there's a security update to OpenSSL, there's a need for a patch to the CPython source tree. That's not a huge overhead, but it's busy work that doesn't really need to be done.

I've we're going to keep the "auto download" behavior for developer convenience, I'd argue it would be better to replace a static list of "known-good" versions with a mechanism that retrieves the list of available artefacts and looks for the latest one (either by manually probing for predictable URLs, or by hitting the GitHub API and sorting the results).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file OS-android topic-SSL type-security A security issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants