Skip to content

gh-123610: Added missing windows handle types to wintypes.py #123721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 16 commits into from

Conversation

rruuaanng
Copy link
Contributor

@rruuaanng rruuaanng commented Sep 5, 2024

I fixed the issue with missing handles that was mentioned in #123610 and added the missing handle types.

@rruuaanng rruuaanng changed the title Added missing windows handle types to wintypes.py gh-123610: Added missing windows handle types to wintypes.py Sep 5, 2024
@jlallas384
Copy link
Contributor

jlallas384 commented Sep 5, 2024

HFILE should be an int and HRESULT is a LONG

@rruuaanng
Copy link
Contributor Author

T

HFILE should be an int and HRESULT is a LONG``HFILE 应为 int,HRESULTLONG

Sorry, I didn't notice, I'm currently making modifications

@rruuaanng rruuaanng requested a review from picnixz September 5, 2024 14:10
Copy link
Member

@picnixz picnixz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another core dev will need to decide whether to keep or not the NEWS entry. If we were to keep it, I think we should add a What's New entry instead and make the NEWS entry shorter.

@rruuaanng rruuaanng requested a review from a team as a code owner September 6, 2024 03:31
@rruuaanng rruuaanng closed this Sep 14, 2024
@rruuaanng rruuaanng reopened this Sep 14, 2024
@rruuaanng rruuaanng closed this Sep 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants