-
-
Notifications
You must be signed in to change notification settings - Fork 31.9k
GH-95468: Prevent argparse from removing --
in cases where used to delineate positional args
#124145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
savannahostrowski
commented
Sep 16, 2024
•
edited by bedevere-app
bot
Loading
edited by bedevere-app
bot
- Issue: argparse.ArgumentParser silently swallows multiple -- (double dash) #95468
Perhaps @serhiy-storchaka you can take a look? I think you updated this conditional and added some additional tests for -- in #114814 |
This comment was marked as off-topic.
This comment was marked as off-topic.
This does not work for This issue may require a fix at different level. I'll try to resolve it. |
Ah, thanks for the review, @serhiy-storchaka. It was my mistake to expect tests to catch some of these. I can take another look and add additional tests here. |
@serhiy-storchaka I've updated the PR. Does this cover the test cases you were thinking of? Or do you already have another PR in progress? |
This is not enough. |
I am afraid that my reaction may not have seemed very friendly to you. In this case, I apologize and make sure that the reason for this is only my bad English and my fatigue. I didn't mean anything bad. It's just that in this case your approach was a dead end, this problem needed to be solved at another level. I've already spent half a day creating a solution, and creating a new PR was much easier than leading you to incrementally modify your PR. It happens to everyone, even major developers close their PRs. My main mistake was that I did not know words how to say this to you. I look forward to working with you. |