gh-123378: fix a crash in UnicodeError.__str__
#124935
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
encukou
reviewed
Oct 4, 2024
picnixz
changed the title
Unicode{Encode,Decode}Error.__str__UnicodeError.__str__
picnixz
force-pushed
the
fix/unicode-error-str-123378
branch
from
5ca7f92 to
360c1a5
Compare
vstinner
reviewed
Oct 7, 2024
Lib/test/test_exceptions.py
Outdated
| @@ -1336,6 +1337,26 @@ def test_unicode_errors_no_object(self): | |||
| for klass in klasses: | |||
| self.assertEqual(str(klass.__new__(klass)), "") | |||
|
|
|||
| def test_unicode_error_str_gh_123378(self): | |||
| for formatter, start, end, obj in product( | |||
| (str, repr), | |||
There was a problem hiding this comment.
Testing repr() if we already test str() sounds redundant to me. Is it really worth it?
There was a problem hiding this comment.
No you're right. I'll remove it.
Lib/test/test_exceptions.py
Outdated
| @@ -1336,6 +1337,26 @@ def test_unicode_errors_no_object(self): | |||
| for klass in klasses: | |||
| self.assertEqual(str(klass.__new__(klass)), "") | |||
|
|
|||
| def test_unicode_error_str_gh_123378(self): | |||
There was a problem hiding this comment.
The purpose of the test is unclear to me, it just calls str(). Please add a comment to explain that you check that str() doesn't crash with a reference to the issue.
Lib/test/test_exceptions.py
Outdated
| (str, repr), | ||
| range(-5, 5), | ||
| range(-5, 5), | ||
| ('', 'a', '123', '1234', '12345', 'abc123'), |
There was a problem hiding this comment.
Suggested change
| ('', 'a', '123', '1234', '12345', 'abc123'), | |
| ('', 'a', 'abc', 'abcde', 'abcdef'), |
vstinner
added
needs backport to 3.12
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 8, 2024
(cherry picked from commit ba14dfa) Co-authored-by: Bénédikt Tran <[email protected]>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 8, 2024
(cherry picked from commit ba14dfa) Co-authored-by: Bénédikt Tran <[email protected]>
|
GH-125098 is a backport of this pull request to the 3.12 branch. |
|
GH-125099 is a backport of this pull request to the 3.13 branch. |
vstinner
pushed a commit
that referenced
this pull request
Oct 8, 2024
…125098) gh-123378: fix a crash in `UnicodeError.__str__` (GH-124935) (cherry picked from commit ba14dfa) Co-authored-by: Bénédikt Tran <[email protected]>
vstinner
pushed a commit
that referenced
this pull request
Oct 8, 2024
…125099) gh-123378: fix a crash in `UnicodeError.__str__` (GH-124935) (cherry picked from commit ba14dfa) Co-authored-by: Bénédikt Tran <[email protected]>
efimov-mikhail
pushed a commit
to efimov-mikhail/cpython
that referenced
this pull request
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @encukou @serhiy-storchaka @vstinner
startvalues onPyUnicodeErrorObject#123378