Skip to content

gh-125139: use _PyRecursiveMutex in _thread.RLock #125144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Oct 14, 2024

Conversation

kumaraditya303
Copy link
Contributor

@kumaraditya303 kumaraditya303 commented Oct 8, 2024

@kumaraditya303
Copy link
Contributor Author

kumaraditya303 commented Oct 8, 2024

Current status:

  • Windows failed to build on CI but passed locally.
  • WASI failure, no idea
  • Thread sanitizer failed on CI but passes locally.

@colesbury
Copy link
Contributor

Oh, my hypothesis for the WASI failure is:

  • PyThread_get_thread_ident_ex() is zero on WASI
  • So an unlocked recursive mutex looks like it's owned by the current thread

@kumaraditya303 kumaraditya303 merged commit 67f6e08 into python:main Oct 14, 2024
35 checks passed
@kumaraditya303 kumaraditya303 deleted the rlock branch October 14, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants