-
-
Notifications
You must be signed in to change notification settings - Fork 31.9k
Typo: delete duplicated test case #12662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA). Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. You can check yourself to see if the CLA has been received. Thanks again for your contribution, we look forward to reviewing it! |
@nanjekyejoannah Thanks.Title fixed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. commit where tests were changed : bd48d27 .
Comparing with other tests, it is more likely this test should contain |
edit line 112 . Before: ('(?s)a.b', 'a\nb', SUCCEED, 'found', 'a\nb'), After: ('(?s)a.b', 'a\rb', SUCCEED, 'found', 'a\rb'),
@serhiy-storchaka The Azure Pipeline PR was failed because |
Thank you for your contribution @MakDon! |
I can see one more copy of |
@serhiy-storchaka Does this file in general have duplicates as part of the same list for some reason? Line 209 in ded4737
Line 372 in ded4737
Adding below to the file I can see some more duplicates : test_map = {}
for test in tests:
key = test[0] + test[1]
if key not in test_map:
test_map[key] = None
else:
print(f"duplicate {test[0]} {test[1]}")
print("Set returns ", len(set(map(lambda x: (x[0] + x[1]), tests))))
print("List returns ", len(tests))
|
It seems that this tests are combined from several parts such as |
Delete a duplicated test case in re_tests.
In the original version, line 109 seems to be the same with 112, which means line 112 is duplicated.
According to "Trivial changes, like fixing a typo, do not need an issue.", no issue was created in the https://bugs.python.org.