gh-125063: marshal: Add version 5, improve documentation #126829
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
encukou
commented
Nov 14, 2024
Comment on lines
+124
to
125
| assert(Py_MARSHAL_VERSION >= 5); | ||
| PyObject *marshalled = PyMarshal_WriteObjectToString(code, Py_MARSHAL_VERSION); |
There was a problem hiding this comment.
In the Makefile, _freeze_module doesn't depend on marshal.h, but it needs to be rebuilt when Py_MARSHAL_VERSION switches to 5.
Instead of properly changing the Makefile, which would be another rabbit hole, I decided to touch _freeze_module.c instead.
encukou
added
docs
mdboom
approved these changes
Nov 14, 2024
|
I also learned a lot. |
picnixz
pushed a commit
to picnixz/cpython
that referenced
this pull request
Dec 8, 2024
…nGH-126829) * Document that slices can be marshalled * Deduplicate and organize the list of supported types in docs * Organize the type code list in marshal.c, to make it more obvious that this is a versioned format * Back-fill some historical info Co-authored-by: Michael Droettboom <[email protected]>
ebonnal
pushed a commit
to ebonnal/cpython
that referenced
this pull request
Jan 12, 2025
…nGH-126829) * Document that slices can be marshalled * Deduplicate and organize the list of supported types in docs * Organize the type code list in marshal.c, to make it more obvious that this is a versioned format * Back-fill some historical info Co-authored-by: Michael Droettboom <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on #126804, but I followed the rabbit hole much deeper.
In Python 3.14,
sliceobjects can be marshalled.This calls for a new
versionof the marshal format, so that backwards-incompatibleobjects are rejected at serialization time.
📚 Documentation preview 📚: https://cpython-previews--126829.org.readthedocs.build/