bpo-36583: Do not swallow exceptions in the _ssl module. #12756
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think the relevant issue is https://bugs.python.org/issue36583 ? https://bugs.python.org/issue339827 returns 404 but @bedevere-bot seems to have accepted it. Seems to be known issue : python/bedevere#15 |
serhiy-storchaka
changed the title
|
Thanks @tirkarthi. I have no idea from where this number came. I just pasted it from the clipboard, but seems something messed. |
tiran
reviewed
Apr 10, 2019
| PyObject *cadata_ascii = NULL; | ||
|
|
||
| if (PyObject_GetBuffer(cadata, &buf, PyBUF_SIMPLE) == 0) { | ||
| if (PyUnicode_Check(cadata)) { |
There was a problem hiding this comment.
Why did you change the order of checks here? What was wrong with the original code?
There was a problem hiding this comment.
Nothing wrong, but it seems to me that checking for unicode string prior to checking for bytes-like objects is more common. If you prefer, I'll return the former order. This will minimize the diff.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue36583