Skip to content

gh-87138: convert SHA-3 object type to heap type #127670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 8, 2024

Conversation

picnixz
Copy link
Member

@picnixz picnixz commented Dec 6, 2024

This is a follow-up to #26374.

I took the liberty of:

  • adding an assert() on the rate
  • removing a redundant if (my IDE would warn me! and PyMem_Free() already checks for NULL)
  • suppress the return type of _sha3_clear() to make the IDE happy as well.

@picnixz picnixz force-pushed the feat/hashlib/sha3/heap-type-87138 branch from acbe3d1 to e23eeee Compare December 8, 2024 13:18
@gpshead gpshead self-assigned this Dec 8, 2024
@gpshead gpshead merged commit 3b78409 into python:main Dec 8, 2024
43 checks passed
@picnixz picnixz deleted the feat/hashlib/sha3/heap-type-87138 branch December 8, 2024 17:53
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants