-
-
Notifications
You must be signed in to change notification settings - Fork 31.8k
gh-127896: Add missing document of PySequence_In
#127979
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: Sergey B Kirpichev <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but please add news and document that in whatsnew/3.14.rst (C API Changes->Deprecated).
Thanks. Added news and whatsnew entry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I second on above suggestion.
Co-authored-by: Petr Viktorin <[email protected]>
Alias for :c:func:`PySequence_Contains`. | ||
.. deprecated:: 3.14 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have this fancy thing these days:
.. deprecated:: 3.14 | |
.. deprecated:: next | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We do, and it makes backporting easier, but backporting a deprecation doesn't make much sense :)
…GH-127979) Co-authored-by: Sergey B Kirpichev <[email protected]>
Fixes gh-127896 .
📚 Documentation preview 📚: https://cpython-previews--127979.org.readthedocs.build/en/127979/c-api/sequence.html#c.PySequence_In