Skip to content

gh-127896: Add missing document of PySequence_In #127979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Dec 16, 2024
Merged

Conversation

koyuki7w
Copy link
Contributor

@koyuki7w koyuki7w commented Dec 16, 2024

@bedevere-app bedevere-app bot added docs Documentation in the Doc dir skip news labels Dec 16, 2024
Co-authored-by: Sergey B Kirpichev <[email protected]>
Copy link
Member

@skirpichev skirpichev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but please add news and document that in whatsnew/3.14.rst (C API Changes->Deprecated).

@koyuki7w koyuki7w requested a review from skirpichev December 16, 2024 07:52
@koyuki7w
Copy link
Contributor Author

Thanks. Added news and whatsnew entry.

Copy link
Member

@skirpichev skirpichev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I second on above suggestion.

@koyuki7w koyuki7w requested a review from encukou December 16, 2024 10:23
Alias for :c:func:`PySequence_Contains`.
.. deprecated:: 3.14
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have this fancy thing these days:

Suggested change
.. deprecated:: 3.14
.. deprecated:: next

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do, and it makes backporting easier, but backporting a deprecation doesn't make much sense :)

@encukou encukou merged commit 52d552c into python:main Dec 16, 2024
25 checks passed
@koyuki7w koyuki7w deleted the doc-fix-2 branch December 16, 2024 14:40
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

PySequence_In is not documented
4 participants