Skip to content

gh-127946: Use a critical section for CFuncPtr attributes #128109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Dec 20, 2024
Merged

gh-127946: Use a critical section for CFuncPtr attributes #128109

merged 10 commits into from
Dec 20, 2024

Conversation

ZeroIntensity
Copy link
Member

@ZeroIntensity ZeroIntensity commented Dec 20, 2024 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Dec 20, 2024
Closed
@ZeroIntensity ZeroIntensity added the needs backport to 3.13 bugs and security fixes label Dec 20, 2024
@encukou encukou merged commit ba45e5c into python:main Dec 20, 2024
40 of 41 checks passed
@encukou
Copy link
Member

encukou commented Dec 20, 2024

Thank you!

@miss-islington-app
Copy link

Thanks @ZeroIntensity for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Sorry, @ZeroIntensity and @encukou, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker ba45e5cdd41a39ce0b3de08bdcfa9d8e28e0e4f3 3.13

@encukou
Copy link
Member

encukou commented Dec 20, 2024

I wouldn't mind skipping the backport; the bug is only in experimental builds.

@ZeroIntensity
Copy link
Member Author

Generally, we do backport thread safety fixes to 3.13. I'm happy to leave it though!

@ZeroIntensity ZeroIntensity deleted the cdll-thread-safety branch December 20, 2024 13:46
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Dec 23, 2024
@ZeroIntensity @srinivasreddy
pythongh-127946: Use a critical section for CFuncPtr attributes (py…
952fc1f 
…thonGH-128109)
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Jan 8, 2025
@ZeroIntensity @srinivasreddy
pythongh-127946: Use a critical section for CFuncPtr attributes (py…
dca4d7c 
…thonGH-128109)
@ZeroIntensity ZeroIntensity removed the needs backport to 3.13 bugs and security fixes label Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@encukou encukou Awaiting requested review from encukou

Assignees

@encukou encukou

Labels
topic-ctypes topic-free-threading
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ZeroIntensity @encukou