Skip to content

[3.7] fix typo in gzip.py (GH-12928) #12933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[3.7] fix typo in gzip.py (GH-12928) #12933

wants to merge 1 commit into from

Conversation

miss-islington
Copy link
Contributor

(cherry picked from commit 4f5a349)

Co-authored-by: Maximilian Nöthe [email protected]

@maxnoe @miss-islington
fix typo in gzip.py (pythonGH-12928)
2d1a53d 
(cherry picked from commit 4f5a349)

Co-authored-by: Maximilian Nöthe <[email protected]>
@bedevere-bot bedevere-bot mentioned this pull request Apr 24, 2019
Merged
@miss-islington
Copy link
Contributor Author

@maxnoe and @methane: Status check is done, and it's a success ✅ .

@miss-islington
Copy link
Contributor Author

Sorry, I can't merge this PR. Reason: Required status check "continuous-integration/appveyor/pr" is expected..

@miss-islington
Copy link
Contributor Author

@maxnoe and @methane: Status check is done, and it's a success ✅ .

@miss-islington
Copy link
Contributor Author

Sorry, I can't merge this PR. Reason: Required status check "continuous-integration/appveyor/pr" is expected..

@methane methane closed this Apr 24, 2019
@methane methane reopened this Apr 24, 2019
@miss-islington
Copy link
Contributor Author

@maxnoe and @methane: Status check is done, and it's a success ✅ .

2 similar comments
@miss-islington
Copy link
Contributor Author

@maxnoe and @methane: Status check is done, and it's a success ✅ .

@miss-islington
Copy link
Contributor Author

@maxnoe and @methane: Status check is done, and it's a success ✅ .

@miss-islington
Copy link
Contributor Author

Sorry, I can't merge this PR. Reason: Required status check "continuous-integration/appveyor/pr" is expected..

@miss-islington
Copy link
Contributor Author

Sorry, I can't merge this PR. Reason: 2 of 5 required status checks have not succeeded: 1 expected and 1 pending..

1 similar comment
@miss-islington
Copy link
Contributor Author

Sorry, I can't merge this PR. Reason: 2 of 5 required status checks have not succeeded: 1 expected and 1 pending..

@miss-islington miss-islington deleted the backport-4f5a349-3.7 branch April 24, 2019 12:38
@miss-islington
Copy link
Contributor Author

@maxnoe and @methane: Status check is done, and it's a failure ❌ .

1 similar comment
@miss-islington
Copy link
Contributor Author

@maxnoe and @methane: Status check is done, and it's a failure ❌ .

ChrisDenton added a commit to ChrisDenton/cpython that referenced this pull request Feb 3, 2025
@ChrisDenton
pythongh-12933: fix import error over nfs on Windows
ab8e389 
On Windows, realpath uses `GetFinalPathNameByHandleW` to resolve paths. This returns paths starting with a `\\?\` prefix, which is usually not what we want.

This change attempts to remove the prefix for \\?\UNC\ paths. A similar thing was already done for drive paths such as \\?\C:\.
ChrisDenton added a commit to ChrisDenton/cpython that referenced this pull request Feb 3, 2025
@ChrisDenton
pythongh-12933: fix import error over nfs on Windows
e496899 
On Windows, realpath uses `GetFinalPathNameByHandleW` to resolve paths. This returns paths starting with a `\\?\` prefix, which is usually not what we want.

This change attempts to remove the prefix for \\?\UNC\ paths. A similar thing was already done for drive paths such as \\?\C:\.
ChrisDenton added a commit to ChrisDenton/cpython that referenced this pull request Feb 3, 2025
@ChrisDenton
pythongh-12933: fix import error over nfs on Windows
ca4b741 
On Windows, realpath uses `GetFinalPathNameByHandleW` to resolve paths. This returns paths starting with a `\\?\` prefix, which is usually not what we want.

This change attempts to remove the prefix for \\?\UNC\ paths. A similar thing was already done for drive paths such as \\?\C:\.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@methane methane methane approved these changes

Assignees
No one assigned
Labels
awaiting merge skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@miss-islington @methane @the-knights-who-say-ni @bedevere-bot @maxnoe