Skip to content

gh-111495: Add PyFile tests #129449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 30, 2025
Merged

gh-111495: Add PyFile tests #129449

merged 5 commits into from
Jan 30, 2025

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Jan 29, 2025

Add tests for the following functions in test_capi.test_file:

  • PyFile_FromFd()
  • PyFile_GetLine()
  • PyFile_NewStdPrinter()
  • PyFile_WriteObject()
  • PyFile_WriteString()
  • PyObject_AsFileDescriptor()

Add Modules/_testlimitedcapi/file.c file.

Remove now redundant test_embed.StdPrinterTests.

Add tests for the following functions in test_capi.test_file:

* PyFile_FromFd()
* PyFile_GetLine()
* PyFile_NewStdPrinter()
* PyFile_WriteObject()
* PyFile_WriteString()
* PyObject_AsFileDescriptor()

Add Modules/_testlimitedcapi/file.c file.

Remove now redundant test_embed.StdPrinterTests.
@vstinner vstinner requested review from a team and erlend-aasland as code owners January 29, 2025 16:51
@bedevere-app bedevere-app bot mentioned this pull request Jan 29, 2025
10 tasks
@vstinner vstinner merged commit 4ca9fc0 into python:main Jan 30, 2025
41 checks passed
@vstinner vstinner deleted the test_capi_file branch January 30, 2025 17:05
vstinner added a commit to vstinner/cpython that referenced this pull request Jan 30, 2025
Add tests for the following functions in test_capi.test_file:

* PyFile_FromFd()
* PyFile_GetLine()
* PyFile_NewStdPrinter()
* PyFile_WriteObject()
* PyFile_WriteString()
* PyObject_AsFileDescriptor()

Add Modules/_testlimitedcapi/file.c file.

Remove test_embed.StdPrinterTests which became redundant.

(cherry picked from commit 4ca9fc0)
@bedevere-app
Copy link

bedevere-app bot commented Jan 30, 2025

GH-129477 is a backport of this pull request to the 3.13 branch.

vstinner added a commit that referenced this pull request Jan 30, 2025
gh-111495: Add PyFile tests (#129449)

Add tests for the following functions in test_capi.test_file:

* PyFile_FromFd()
* PyFile_GetLine()
* PyFile_NewStdPrinter()
* PyFile_WriteObject()
* PyFile_WriteString()
* PyObject_AsFileDescriptor()

Add Modules/_testlimitedcapi/file.c file.

Remove test_embed.StdPrinterTests which became redundant.

(cherry picked from commit 4ca9fc0)
vstinner added a commit that referenced this pull request Jan 31, 2025
[3.13] gh-111495: Add PyFile tests (#129449) (#129477)

gh-111495: Add PyFile tests (#129449)

Add tests for the following functions in test_capi.test_file:

* PyFile_FromFd()
* PyFile_GetLine()
* PyFile_NewStdPrinter()
* PyFile_WriteObject()
* PyFile_WriteString()
* PyObject_AsFileDescriptor()

Remove test_embed.StdPrinterTests which became redundant.

(cherry picked from commit 4ca9fc0)
(cherry picked from commit 9a59a51)
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Feb 7, 2025
Add tests for the following functions in test_capi.test_file:

* PyFile_FromFd()
* PyFile_GetLine()
* PyFile_NewStdPrinter()
* PyFile_WriteObject()
* PyFile_WriteString()
* PyObject_AsFileDescriptor()

Add Modules/_testlimitedcapi/file.c file.

Remove test_embed.StdPrinterTests which became redundant.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant