-
-
Notifications
You must be signed in to change notification settings - Fork 32k
gh-127146: Update test skips for Emscripten 4.0.2 #129474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-127146: Update test skips for Emscripten 4.0.2 #129474
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fairly straightforward; a couple of small suggestions/questions inline.
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
Co-authored-by: Russell Keith-Magee <[email protected]>
Okay I applied the suggestions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like you missed one (the continue/return change) - but with that merged, looks like everything is working as expected.
|
I can't see any reason why this test failure would have been caused by this PR. |
Thanks for the reviews @freakboy3742! |
Updates test skips to reflect capabilities of Emscripten 4.0.2.
Updates test skips to reflect capabilities of Emscripten 4.0.2.
Emscripten 4.0.2 brought in a few new file system bug fixes.