-
-
Notifications
You must be signed in to change notification settings - Fork 32k
gh-128231: Use runcode()
return value for failing early
#129488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Should we document the new sentinel? It seems the |
1004941
to
71c4a5f
Compare
I don't think that we should document it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you
@encukou (Pinging as discussed on stream) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might as well throw my approval on here too. I think this makes sense.
Will also ping @asvetlov as he had reviewed my first PR, relevant to the (asyncio) REPL. |
This makes sense to me! I'll give a chance to the REPL experts to review, but if there are no objections next week I plan to merge this. |
…onGH-129488) (cherry picked from commit 7ed3dc6) Co-authored-by: Bartosz Sławecki <[email protected]>
GH-130513 is a backport of this pull request to the 3.13 branch. |
|
|
Uh oh, that looks related. Should we revert the 3.13 PR @hugovk? |
|
|
|
|
|
|
|
|
|
|
The 3.13 backport is failing GHA and buildbots, it must have gotten out of sync between last CI run and merge.
Let's revert the 3.13 backport to get the CI back to green. Edit: revert PR #131834 |
|
…ing early (pythonGH-129488) (python#130513)" This reverts commit 8f6a9aa.
|
|
|
|
Closes gh-128231.
Any potential downstream subclasses (which are hard to imagine, but who knows, Python is big) that override
runcode()
can introduce this protocol gradually, with the old behavior preserved until then (backward compatibility).